Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It loses its state on every parent setState() #32

Closed
rocboronat opened this issue Oct 1, 2021 · 6 comments
Closed

It loses its state on every parent setState() #32

rocboronat opened this issue Oct 1, 2021 · 6 comments
Labels
waiting for response Waiting for response from the author

Comments

@rocboronat
Copy link

Hello!

We went on beta (join it if you want hihi) and found a new issue. When the parent of the picker calls setState(), the emoji picker loses its state and goes back to the first page.

Do you know any quick way to fix it? Or should we change the emoji picker itself and release a new version?

Here's an example that showcases the issue. In this case, when we scroll the list, we call a setState() to show or hide the FAB. Now I'm going to do it with a ValueNotifier to avoid that setState() only for a part of the screen, but well, the issue is there.

EmojiPickerIssue2

As usual, thanks for the plugin and the support! 👍

@Fintasys
Copy link
Owner

Fintasys commented Oct 2, 2021

That doesn't look good 😅 Which version are you using? Did you also try current master?

@Fintasys Fintasys added the waiting for response Waiting for response from the author label Oct 4, 2021
@rocboronat
Copy link
Author

We are on 1.0.7 and nope, didn't try current master :·D

@Fintasys
Copy link
Owner

Fintasys commented Oct 7, 2021

@rocboronat Would you consider to give it a try? I couldn't reproduce the issue on my side as far as I understood it. Would be helpful if you could test it with master or make a sample to reproduce the issue 🙇 by the way I've checked your app and it looks great, glad to see my widget being used :)

@rocboronat
Copy link
Author

Haha! Good news! After building the sample project I realized that moving from 1.0.7 to master just fixes the issue 😄

In case it helps you in any way (which I doubt, haha!) here's the sample: https://github.com/rocboronat/emoji_picker_flutter_issue

So... moving QuitNow to master! If you want, we can test it on production (🤫🤫🤫) and give you a green light to release a new version 😄

@Fintasys
Copy link
Owner

Fintasys commented Oct 7, 2021

Oh glad to hear that 😁 Also thx for providing the sample, it might come handy at others times / bugs.
I'm thinking of releasing current state as new version soon 🤔 If I can get some confirmation I would of course feel much safer tho 🤣

@rocboronat
Copy link
Author

Hey! Hi again! 👋 I think b42052ea6bafc0fc8ab27e77b9f8994a86d030d3 totally fixes the issue. Oh, and we have it released to the 100% of our users and nobody said anything bad about the keyboard. So I think you can be confident it works as expectet, hehehe! Thanks a lot, @Fintasys 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for response Waiting for response from the author
Projects
None yet
Development

No branches or pull requests

2 participants