[Feature] Add EmojiPickerUtils for advanced usage #38

zhourengui · 2022-01-04T10:38:07Z

close: #37

I encountered a need to search for emojis feature, but I can’t get all emojis, so I think a public method class should be implement for the convenience of expansion.

I think this change should be very useful, for example:

when our package adds a category, we don’t need to modify it in multiple places
want to expand the function of searching emoticons, at this time, we need to get all the expressions, this method does not require the user to reassemble all the expression data.

lib/src/emoji_picker_utils.dart

Fintasys · 2022-01-04T13:33:11Z

Overall I understand what you want to achieve and it does sounds good to me. Beside my comments above I think it would be great if you could also adjust the readme for this change and explain how it can be used.

zhourengui · 2022-01-04T14:48:15Z

Overall I understand what you want to achieve and it does sounds good to me. Beside my comments above I think it would be great if you could also adjust the readme for this change and explain how it can be used.

I have modified it, thank you very much for your feedback.

zhourengui · 2022-01-05T08:59:46Z

I added the addEmojiToRecentlyUsedfang method, because it should be useful when expanding

Fintasys

Thx for addressing the previous comments and your efforts! I took a closer look now and found some other issues, place have a look ! 🙇

CHANGELOG.md

README.md

lib/src/emoji_picker.dart

lib/src/emoji_picker_utils.dart

…engui/emoji_picker_flutter into feature/emoji_picker_utils # Conflicts: # lib/src/emoji_picker_utils.dart

zhourengui · 2022-01-06T10:04:03Z

Your point of view is very correct. I didn’t consider the compatibility issue at the beginning. The method I’m exposing now is to get all the available category emoji and all the available emoji entities and search emoticons.

Fintasys

Sorry more comments :) Let me know if I should support you 👍 Thanks for your hard work

Fintasys · 2022-01-08T06:32:51Z

lib/src/emoji_picker_utils.dart

+  static Future<Map<Category, Map<String, String>?>?>
+      getAvailableCategoryEmoji() async {
+    if (_availableCategoryEmoji == null) {
+      // Filter recent category emojis
+      final categories =
+          Category.values.where((category) => category != Category.RECENT);
+
+      // Get all available emojis from cached
+      final futures = categories.map((category) async {
+        final emojis = await restoreFilteredEmojis(category.name);
+        return emojis;
+      });
+
+      final allAvailableEmojis = await Future.wait(futures);
+
+      _availableCategoryEmoji =
+          Map.fromIterables(categories, allAvailableEmojis);
+    }
+    return _availableCategoryEmoji;
+  }


In case emoji-picker hasn't been displayed at least once, there are no emojis cached and this method would return an empty Map. Could we maybe extract the logic inside _updateEmojis() instead into another helper class (non-static, mockable for tests) together with restoreFilteredEmojis?

I also considered this problem at first, but what I thought was that since this tool class should be used only when the pop-up window is used, there may be a problem with my idea.😄

lib/src/emoji_picker_utils.dart

Fintasys · 2022-01-08T06:41:12Z

lib/src/emoji_picker_utils.dart

+  }
+
+  /// Add an emoji to recently used list or increase its counter
+  static Future<List<RecentEmoji>> addEmojiToRecentlyUsed(


I was wondering what's the use case for this method? How could it be used outside of the Widget?
If it doesn't serve an usage outside of the widget we could also move it to extra helper class

For example, when searching for expressions, a certain expression is used, and this expression needs to be added to the recent use, so I moved it here

lib/src/emoji_picker.dart

zhourengui · 2022-01-09T11:57:07Z

I have already changed it, I believe this is the best version, and I have tested it locally with version 2.0.1 of flutter, and I have not found any problems for the time being. thank you very much for the feedback these days.😃

zhourengui · 2022-01-10T01:18:27Z

The default value of the recentsLimit parameter of the addEmojiToRecentlyUsed method should be changed to 28. If I don't need to modify the others, please help me change it.

Fintasys

Awesome ! we are almost done - just a few little more comments 🙏

lib/src/emoji_picker_extended_utils.dart

lib/src/emoji_picker_internal_utils.dart

zhourengui · 2022-01-10T15:31:56Z

It has been revised, although the process is very difficult, but the ending is good.😃

Fintasys

I've tested a lot and realized that there were few issues left

search was case sensitive
addEmojiToRecentlyUsed didn't update the widget's recent list
Took me 2 days to figure out a good way and ended up making a PR. Hope you don't mind and can take a look to my changes. I thought that's easier than explaining what I mean.
Fix addEmojiToRecentlyUsed zhourengui/emoji_picker_flutter#1

Fintasys · 2022-01-11T14:14:02Z

lib/src/emoji_picker_utils.dart

+    }
+
+    return _allAvailableEmojiEntities
+        .where((emoji) => emoji.name.contains(keyword))


Search seems to be case-sensitive, I think it would be better if not 😅

…ements Fix addEmojiToRecentlyUsed

Fintasys

@zhourengui Sorry for the delay I was busy. Thank you for your hard work, I think it's good to go now. I will improve the documentation as you mentioned in another PR to make it easier for me. Also I have some other changes related to the emoji's that I want to do first before releasing it as a new version, so please be patient a bit more. You can use the master directly in your app if you need the changes asap.

zhourengui · 2022-01-17T13:19:15Z

@zhourengui Sorry for the delay I was busy. Thank you for your hard work, I think it's good to go now. I will improve the documentation as you mentioned in another PR to make it easier for me. Also I have some other changes related to the emoji's that I want to do first before releasing it as a new version, so please be patient a bit more. You can use the master directly in your app if you need the changes asap.

It's okay, don't worry, I'm currently using a temporary tool class in my project to solve the problem, and when everything is done, I'm going to upgrade.

feature emoji picker utils

bfad7f6

zhourengui mentioned this pull request Jan 4, 2022

Search option for emoji? #37

Closed

Fintasys linked an issue Jan 4, 2022 that may be closed by this pull request

Search option for emoji? #37

Closed

Fintasys reviewed Jan 4, 2022

View reviewed changes

lib/src/emoji_picker_utils.dart Outdated Show resolved Hide resolved

Fintasys reviewed Jan 4, 2022

View reviewed changes

lib/src/emoji_picker_utils.dart Outdated Show resolved Hide resolved

rengui-hs added 2 commits January 4, 2022 22:45

Optimize to get category emoji

300748a

Update modification log and usage

31b81cf

update emoji picker utils to add addEmojiToRecentlyUsed

5eb1270

Update the recentsLimit of addEmojiToRecentlyUsed

fd910e2

Fintasys reviewed Jan 5, 2022

View reviewed changes

lib/src/emoji_picker_utils.dart Outdated Show resolved Hide resolved

rengui-hs added 2 commits January 6, 2022 17:50

Update emoji picker utils provides methods

8b89488

Merge branch 'feature/emoji_picker_utils' of https://github.com/zhour…

f6d3e94

…engui/emoji_picker_flutter into feature/emoji_picker_utils # Conflicts: # lib/src/emoji_picker_utils.dart

Fintasys reviewed Jan 8, 2022

View reviewed changes

feature add EmojiPickerInternalUtils and EmojiPickerExtendedUtils

703e50e

Fintasys reviewed Jan 10, 2022

View reviewed changes

Update EmojiPickerUtils

cf769e5

rengui-hs and others added 3 commits January 11, 2022 00:14

Update EmojiPickerUtils Changelog and usage docs

a6c950e

Fix addEmojiToRecentlyUsed

d7475e5

Make search case-insensitive

ef48f67

Fintasys reviewed Jan 12, 2022

View reviewed changes

Merge pull request #1 from Fintasys/feature/emoji_picker_utils_improv…

8b9ec3b

…ements Fix addEmojiToRecentlyUsed

Fintasys approved these changes Jan 17, 2022

View reviewed changes

Fintasys changed the title ~~feature emoji picker utils~~ [Feature] Add EmojiPickerUtils for advanced usage Jan 17, 2022

Fintasys merged commit 10d4be5 into Fintasys:master Jan 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature] Add EmojiPickerUtils for advanced usage #38

[Feature] Add EmojiPickerUtils for advanced usage #38

zhourengui commented Jan 4, 2022 •

edited by Fintasys

Fintasys commented Jan 4, 2022

zhourengui commented Jan 4, 2022

zhourengui commented Jan 5, 2022

Fintasys left a comment •

edited

zhourengui commented Jan 6, 2022

Fintasys left a comment

Fintasys Jan 8, 2022

rengui-hs Jan 8, 2022

Fintasys Jan 8, 2022

rengui-hs Jan 8, 2022

zhourengui commented Jan 9, 2022

zhourengui commented Jan 10, 2022

Fintasys left a comment

zhourengui commented Jan 10, 2022

Fintasys left a comment

Fintasys Jan 11, 2022

Fintasys left a comment

zhourengui commented Jan 17, 2022

[Feature] Add EmojiPickerUtils for advanced usage #38

[Feature] Add EmojiPickerUtils for advanced usage #38

Conversation

zhourengui commented Jan 4, 2022 • edited by Fintasys

Fintasys commented Jan 4, 2022

zhourengui commented Jan 4, 2022

zhourengui commented Jan 5, 2022

Fintasys left a comment • edited

Choose a reason for hiding this comment

zhourengui commented Jan 6, 2022

Fintasys left a comment

Choose a reason for hiding this comment

Fintasys Jan 8, 2022

Choose a reason for hiding this comment

rengui-hs Jan 8, 2022

Choose a reason for hiding this comment

Fintasys Jan 8, 2022

Choose a reason for hiding this comment

rengui-hs Jan 8, 2022

Choose a reason for hiding this comment

zhourengui commented Jan 9, 2022

zhourengui commented Jan 10, 2022

Fintasys left a comment

Choose a reason for hiding this comment

zhourengui commented Jan 10, 2022

Fintasys left a comment

Choose a reason for hiding this comment

Fintasys Jan 11, 2022

Choose a reason for hiding this comment

Fintasys left a comment

Choose a reason for hiding this comment

zhourengui commented Jan 17, 2022

zhourengui commented Jan 4, 2022 •

edited by Fintasys

Fintasys left a comment •

edited