Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[technical] Fix warnings for Flutter 3 and update dependencies #74

Merged
merged 4 commits into from Jun 8, 2022
Merged

[technical] Fix warnings for Flutter 3 and update dependencies #74

merged 4 commits into from Jun 8, 2022

Conversation

joshuadeguzman
Copy link
Contributor

This should fix the hot reload issue some projects encountered because of the deprecated warnings.

Tickets

Closes #71

Changes

  • Update packages
  • Remove unnecessary null aware checks

@joshuadeguzman joshuadeguzman changed the title [technical] Add support for Flutter 3 and update dependencies [technical] Fix warnings for Flutter 3 and update dependencies May 19, 2022
@Fintasys
Copy link
Owner

@joshuadeguzman Thanks for your contribution. Sorry I made some changes on master, could you rebase your branch with master? Otherwise your changes look good to me ! Thanks!

@Fintasys Fintasys added the waiting for response Waiting for response from the author label May 24, 2022
@joshuadeguzman
Copy link
Contributor Author

@Fintasys , I pushed the changes. Feel free to review.

@Fintasys
Copy link
Owner

Fintasys commented Jun 2, 2022

@joshuadeguzman The CI check is failing. Probably we need to raise the Flutter version in main.yml as well to at least 2.5.0 ?

@LostInDarkMath
Copy link
Contributor

@Fintasys You need to update to at least Flutter 3, for example use flutter_version: '3.0.1' in main.yml.

@joshuadeguzman
Copy link
Contributor Author

Can you check again @Fintasys ?

@Fintasys Fintasys merged commit 631301e into Fintasys:master Jun 8, 2022
LostInDarkMath pushed a commit to LostInDarkMath/emoji_picker_flutter that referenced this pull request Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for response Waiting for response from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flutter 3 fix
3 participants