Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the library is no longer compatible with the stable compiler #38

Closed
joseluis opened this issue Aug 3, 2021 · 2 comments · Fixed by #39
Closed

the library is no longer compatible with the stable compiler #38

joseluis opened this issue Aug 3, 2021 · 2 comments · Fixed by #39

Comments

@joseluis
Copy link
Contributor

joseluis commented Aug 3, 2021

I noticed it since I only use the stable compiler and I was surprised by the undocumented breaking change.

After the following changes the library doesn't compile in stable anymore:

wasm-bindgen = { version = "^0.2", features = ["serde-serialize", "nightly"] }

#![feature(trait_alias)]

I personally don't think removing stable compatibility is a good idea, specially not just to avoid using an ugly long chain of traits in only 3 places...

For now I've removed the feature and the trait alias definition in my local copy in order to be able to keep working with this lib...

@Firaenix
Copy link
Owner

Firaenix commented Aug 5, 2021

Great point, I actually didn't consider how changing the builds to nightly would impact the usage of the library when other people are using it in Rust. I'll fix that up now.

@joseluis
Copy link
Contributor Author

@Firaenix I found the trait-set crate that would allow if you want to recreate the trait aliases removed in #39, in stable Rust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants