Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Favicon not showing after deploying #267

Open
nicklbaert opened this issue Feb 27, 2023 · 0 comments
Open

[BUG] Favicon not showing after deploying #267

nicklbaert opened this issue Feb 27, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@nicklbaert
Copy link

Action config

      - uses: actions/checkout@v3
      - name: Install dependencies
        run: npm install

      - name: Build & export the NextJS app & copy it into config/hosting
        working-directory: apps/app
        run: |
          npm run build
          npm run export
          cp -R out ../../config/hosting

      - name: Deploy Preview to Firebase Hosting
        id: deploy-preview
        uses: FirebaseExtended/action-hosting-deploy@v0
        with:
          firebaseServiceAccount: '${{ secret }}'
          expires: 5d
          projectId: <project_id>
          entryPoint: ${{ env.WORKING_DIRECTORY }}

Expected behavior

We have a NextJS app with a favicon.ico inside it's public/ directory. When deploying manually using firebase deploy, the favicon shows in the browser as expected. This should also be the case when using this action.

Actual behavior

The preview website after deploying with the above workflow does not have a favicon.

In more detail: The favicon is simply empty. A get request to the favicon's route runs successfully but returns an empty image. This is the response in Postman:

Screenshot 2023-02-27 at 08 48 02

Any help is appreciated.

@nicklbaert nicklbaert added the bug Something isn't working label Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant