-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up test suite from 3.x.x upgrade #734
Comments
sounds good!! |
did you guys just finished the angularfire 2.0 ? I see that the version is 2.0 now ? edit: never mind, just noticed "build:failing" |
Yes, version 2.0.0 of AngularFire has been released and you can see the change log here. This bug is tracking the build failures. We wanted to get the release out instead of waiting for us to tackle all the build failures which seemed more like testing issues than actual code issues. |
See #740 for first batch of improvements |
@AbeHaskins - I think we can close this one now that the tests are fast and run reliably. Please re-open if there was anything else you meant to do. |
As part of merging in #717 to upgrade to the Firebase
3.x.x
SDK, we made a lot of testing changes and the test suite is now pretty unstable and does not pass in Travis. We need to clean things up in general and specifically focus on:tick()
method to force the digest loop to update.set()
to complete.The text was updated successfully, but these errors were encountered: