Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up test suite from 3.x.x upgrade #734

Closed
jwngr opened this issue Jun 1, 2016 · 5 comments
Closed

Clean up test suite from 3.x.x upgrade #734

jwngr opened this issue Jun 1, 2016 · 5 comments
Assignees

Comments

@jwngr
Copy link

jwngr commented Jun 1, 2016

As part of merging in #717 to upgrade to the Firebase 3.x.x SDK, we made a lot of testing changes and the test suite is now pretty unstable and does not pass in Travis. We need to clean things up in general and specifically focus on:

  1. Defining a better tick() method to force the digest loop to update.
  2. Make sure our promise chains are set up properly and that we are waiting for things properly. For example, this test does not wait for the Firebase set() to complete.
  3. Make sure the e2e tests actually pass (e.g. the Todo app has two failing tests).
@jwngr jwngr changed the title Clean up test suite Clean up test suite from 3.x.x upgrade Jun 1, 2016
@juan-orca
Copy link

sounds good!!

@CyrusZei
Copy link

CyrusZei commented Jun 2, 2016

did you guys just finished the angularfire 2.0 ? I see that the version is 2.0 now ?

edit: never mind, just noticed "build:failing"

@jwngr
Copy link
Author

jwngr commented Jun 2, 2016

Yes, version 2.0.0 of AngularFire has been released and you can see the change log here. This bug is tracking the build failures. We wanted to get the release out instead of waiting for us to tackle all the build failures which seemed more like testing issues than actual code issues.

@abeisgoat
Copy link
Contributor

See #740 for first batch of improvements

@jwngr
Copy link
Author

jwngr commented Jul 11, 2016

@AbeHaskins - I think we can close this one now that the tests are fast and run reliably. Please re-open if there was anything else you meant to do.

@jwngr jwngr closed this as completed Jul 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants