Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default FirechatUI shouldn't have to be on DOM #40

Open
Pinpickle opened this issue Jun 14, 2015 · 1 comment
Open

Default FirechatUI shouldn't have to be on DOM #40

Pinpickle opened this issue Jun 14, 2015 · 1 comment

Comments

@Pinpickle
Copy link

It may be desirable to create the UI, and only put in the DOM later on in the application. Or remove it from the DOM, and then put it back in there later on. As it is currently very difficult to destroy a FirechatUI instance (all of those event bindings), being able to use the same one over and over would be very useful.

Currently, this is impossible because there are all sorts of calls using a plain jQuery constructor ($('...')). It really should be searching inside the element that was originally passed to the FirechatUI constructor ($(this._el).find('...')). I know we can create our own UI code, but having a more powerful and re-usable default UI out of the box will save people time!

@katowulf
Copy link

Hello, Christian! Thanks for the suggestions here! We do love getting feedback from the community and this sounds like it would be a wonderful addition. I'll mark this as an enhancement until we have time to discuss the cost/value internally and decide if it's something we want to implement.

If this is a task you'd like to tackle, PR's would certainly be welcome, and posting your initial proposal here as well as some implementation ideas would probably save time and energy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants