Regression on lists support

[iclems]

Following: #54

Hi Michael, it sounds like there is an issue with this fix as it mostly breaks the list support:

if you create a list and try to hit enter on an empty line, it won't work
todos are no longer working (can't be clicked)
text alignment is also broken
The selection issue is clearly improved, though there's still some very tiny issue with a space which appears selected on the next line.

Tell me if I can help!

[mikelehen]

Sorry about that (I definitely should have caught that before checking in). :-( Should be fixed now.

The selected space on the next line when doing line selection isn't trivial to fix. I think currently when you select a full line, codemirror ends up selecting {currentLine, 1} -> {currentLine+1, 1} [the ", 1"s are because the first character is a line sentinel character. And I think that's also why you see the "selected space" on the next line] Visually, it might look better if we changed it to select {currentLine-1, } -> {currentLine, }... but I'm not sure... and I haven't dug into how you'd replace CodeMirror's "select current line" command implementation so you could do that.

I'd certainly accept a pull request, but I probably won't dig into it in the near-term, since I think it's just a minor visual glitch (albeit annoying).

[iclems]

Thanks for this Mike! I'll have a look tomorrow. I'll check all this and answer/comment tomorrow ;-)

[jainp]

The "hit enter on an empty line" issue still isn't working for me. I'm still having that error with the latest codebase.

[mikelehen]

@jainp Can you clarify what behavior you're seeing and what you're expecting? And verify you're using the latest bits from git? When I hit enter on a blank list item, the list item is removed, which I think is the expected behavior.

[jainp]

I'm using the latest from git. When I hit enter, it does remove the list item from the client that made the change but doesn't propagate that change to other connected clients.

[mikelehen]

Agh, you're right. Thanks. Re-opening this.

[mikelehen]

Should be fixed now. Sorry about this!