fix(ui): validate email with the library instead of the RegExp (#7772)

firebase · Jan 4, 2022 · b271b7f · b271b7f
1 parent ae8929d
commit b271b7f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/flutterfire_ui/lib/src/auth/validators.dart b/packages/flutterfire_ui/lib/src/auth/validators.dart
@@ -1,4 +1,5 @@
 import 'package:flutter/widgets.dart';
+import 'package:email_validator/email_validator.dart' as e;
 
 abstract class Validator {
   final String errorText;
@@ -42,15 +43,13 @@ class NotEmpty extends Validator {
   }
 }
 
-final _emailRegexp = RegExp(r'^[a-zA-Z0-9.]+@[a-zA-Z0-9]+\.[a-zA-Z]+');
-
 class EmailValidator extends Validator {
   EmailValidator(String errorText) : super(errorText, []);
 
   @override
   String? validate(String? value) {
     if (value == null) return errorText;
-    return _emailRegexp.hasMatch(value) ? null : errorText;
+    return e.EmailValidator.validate(value) ? null : errorText;
   }
 }
 

diff --git a/packages/flutterfire_ui/pubspec.yaml b/packages/flutterfire_ui/pubspec.yaml
@@ -16,6 +16,7 @@ dependencies:
   collection: ^1.15.0
   crypto: ^3.0.1
   desktop_webview_auth: ^0.0.2
+  email_validator: ^2.0.1
   firebase_auth: ^3.3.4
   firebase_core: ^1.10.2
   firebase_database: ^9.0.4