Skip to content

Commit

Permalink
[firebase_crashlytics][ios] setUserIdentifier incorrectly calls setUs…
Browse files Browse the repository at this point in the history
…erEmail (#1750)

* [fix][ios] setUserIdentifier incorrectly calls setUserEmail
  • Loading branch information
Salakar authored and collinjackson committed Jun 19, 2019
1 parent 487347b commit b4a3cf9
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions packages/firebase_crashlytics/CHANGELOG.md
@@ -1,3 +1,7 @@
## 0.0.4+7

* Fixed an issue where `Crashlytics#setUserIdentifier` incorrectly called `setUserEmail` on iOS.

## 0.0.4+6

* On Android, use actual the Dart exception name instead of "Dart error."
Expand Down
Expand Up @@ -74,7 +74,7 @@ - (void)handleMethodCall:(FlutterMethodCall *)call result:(FlutterResult)result
[[Crashlytics sharedInstance] setUserName:call.arguments[@"name"]];
result(nil);
} else if ([@"Crashlytics#setUserIdentifier" isEqualToString:call.method]) {
[[Crashlytics sharedInstance] setUserEmail:call.arguments[@"identifier"]];
[[Crashlytics sharedInstance] setUserIdentifier:call.arguments[@"identifier"]];
result(nil);
} else {
result(FlutterMethodNotImplemented);
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase_crashlytics/pubspec.yaml
@@ -1,7 +1,7 @@
name: firebase_crashlytics
description: Flutter plugin for Firebase Crashlytics. It reports uncaught errors to the
Firebase console.
version: 0.0.4+6
version: 0.0.4+7
author: Flutter Team <flutter-dev@google.com>
homepage: https://github.com/flutter/plugins/tree/master/packages/firebase_crashlytics

Expand Down

0 comments on commit b4a3cf9

Please sign in to comment.