fix(flutterfire_ui): Upgrade desktop_webview_auth package causing a…

… problem on macOS. (#8151)
firebase · Feb 22, 2022 · da4a1c5 · da4a1c5
1 parent 19c3e9a
commit da4a1c5
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/packages/flutterfire_ui/lib/src/auth/oauth/providers/facebook_provider.dart b/packages/flutterfire_ui/lib/src/auth/oauth/providers/facebook_provider.dart
@@ -49,7 +49,7 @@ class FacebookProviderImpl extends OAuthProvider {
 
   @override
   OAuthCredential fromDesktopAuthResult(AuthResult result) {
-    return FacebookAuthProvider.credential(result.accessToken);
+    return FacebookAuthProvider.credential(result.accessToken!);
   }
 
   @override

diff --git a/packages/flutterfire_ui/lib/src/auth/oauth/providers/google_provider.dart b/packages/flutterfire_ui/lib/src/auth/oauth/providers/google_provider.dart
@@ -59,7 +59,10 @@ class GoogleProviderImpl extends OAuthProvider {
 
   @override
   OAuthCredential fromDesktopAuthResult(AuthResult result) {
-    return GoogleAuthProvider.credential(accessToken: result.accessToken);
+    return GoogleAuthProvider.credential(
+      idToken: result.idToken,
+      accessToken: result.accessToken,
+    );
   }
 }
 

diff --git a/packages/flutterfire_ui/lib/src/auth/oauth/providers/twitter_provider.dart b/packages/flutterfire_ui/lib/src/auth/oauth/providers/twitter_provider.dart
@@ -58,7 +58,7 @@ class TwitterProviderImpl extends OAuthProvider {
   @override
   OAuthCredential fromDesktopAuthResult(AuthResult result) {
     return TwitterAuthProvider.credential(
-      accessToken: result.accessToken,
+      accessToken: result.accessToken!,
       secret: result.tokenSecret!,
     );
   }

diff --git a/packages/flutterfire_ui/pubspec.yaml b/packages/flutterfire_ui/pubspec.yaml
@@ -5,7 +5,7 @@ repository: https://github.com/FirebaseExtended/flutterfire/tree/master/packages
 homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/flutterfire_ui
 
 false_secrets:
- - example/**
+  - example/**
 
 environment:
   sdk: '>=2.12.0 <3.0.0'
@@ -15,7 +15,7 @@ dependencies:
   cloud_firestore: ^3.1.8
   collection: ^1.15.0
   crypto: ^3.0.1
-  desktop_webview_auth: ^0.0.2
+  desktop_webview_auth: ^0.0.4
   email_validator: ^2.0.1
   firebase_auth: ^3.3.7
   firebase_core: ^1.10.2
@@ -46,7 +46,6 @@ flutter:
   assets:
     - assets/icons/
     - assets/countries.json
-
 # To add assets to your package, add an assets section, like this:
 # assets:
 #   - images/a_dot_burr.jpeg