Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding state hoisting in order to have the compose preview available. #4

Closed

Conversation

jgavazzisp
Copy link

Hi there, thanks for creating the project to nudge the community towards the recommended way to work with Firebase.

I just had one suggestion for now which is to do a state hoisting on the screen — I've submitted one example and can do the same for the other ones if you guys are happy with it —.

After doing the state hoisting we can add the preview tag to the screen and enable live edits — when using Android Studio Electric Eel — to have fast feedback on UI changes.

Please feel free to discard the PR if you feel it is not useful.

@google-cla
Copy link

google-cla bot commented Jun 1, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jgavazzisp jgavazzisp closed this Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant