Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebird 3.0.2 allows any protocol version >= 10 to connect, including interbase protocol 14 [CORE5686] #5952

Closed
firebird-issue-importer opened this issue Dec 21, 2017 · 8 comments

Comments

@firebird-issue-importer

Submitted by: @mrotteveel

The following commit in Firebird 3.0.2 allows any protocol >= 10 to connect, including interbase protocol 14 (which is definitely not compatible): 2fdb281

Specifically in src/remote/server/server.cpp accept_connection.

if ((protocol->p_cnct_version >= PROTOCOL_VERSION10 &&
protocol->p_cnct_version <= PROTOCOL_VERSION15) &&

should instead be:

if ((protocol->p_cnct_version == PROTOCOL_VERSION10 ||
protocol->p_cnct_version => PROTOCOL_VERSION11 &&
protocol->p_cnct_version <= PROTOCOL_VERSION15) &&

(and for Firebird 4: PROTOCOL_VERSION16 instead of 15)

See also firebird-support thread "Firebird 3.0.3 no longer compatible with InterBase 7.5.1 clients"

Commits: 2d3424c f8631ec

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Dec 21, 2017

Modified by: @mrotteveel

priority: Major [ 3 ] => Blocker [ 1 ]

Component: API / Client Library [ 10040 ]

Component: Engine [ 10000 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Dec 21, 2017

Modified by: @mrotteveel

summary: Firebird 3.0.2 allows any protocol version >= 10 to connect, including interbase version 14 => Firebird 3.0.2 allows any protocol version >= 10 to connect, including interbase protocol 14

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Dec 21, 2017

Commented by: @hvlad

This is the bug, no doubts, but - why it have blocker priority ?

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Dec 21, 2017

Modified by: @AlexPeshkoff

assignee: Alexander Peshkov [ alexpeshkoff ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Dec 21, 2017

Commented by: @mrotteveel

I marked it as blocker, because it is a regression that I think needs to be fixed before 3.0.3 is released.

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Dec 21, 2017

Modified by: @AlexPeshkoff

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 3.0.3 [ 10810 ]

Fix Version: 4.0 Beta 1 [ 10750 ]

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Dec 22, 2017

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Cannot be tested

@firebird-issue-importer
Copy link
Author

firebird-issue-importer commented Dec 22, 2017

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment