Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't update database-level statistics on every page cache operation. #7814

Closed
hvlad opened this issue Oct 23, 2023 · 1 comment
Closed

Don't update database-level statistics on every page cache operation. #7814

hvlad opened this issue Oct 23, 2023 · 1 comment

Comments

@hvlad
Copy link
Member

hvlad commented Oct 23, 2023

Statistics counters at database-level is shared by all attachments in SS architecture.
Operations in page cache (in particular fetches) is most frequent operations that changes corresponding counters.
When concurrent attachments actively works with page cache and often increments corresponding counters it leads
to the bouncing of memory area where counters allocated between CPU cores, and creates performance penalty.

The improvement is to update database-level stats only when necessary making less changes in common memory.

@hvlad
Copy link
Member Author

hvlad commented Oct 28, 2023

Re-opened to fix failure of QA test for CORE-3625 (#3977)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants