Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace any plain base64 with base64url #70

Open
Firehed opened this issue Feb 14, 2024 · 0 comments · Fixed by #81
Open

Replace any plain base64 with base64url #70

Firehed opened this issue Feb 14, 2024 · 0 comments · Fixed by #81
Milestone

Comments

@Firehed
Copy link
Owner

Firehed commented Feb 14, 2024

Beyond making what's used where quite confusing, the standard is moving towards generally encouraging base64url (i.e. #41).

While supporting the legacy format-shifting APIs becomes a bit more tedious to base64url-shift in client code, I envision any support for it going away by 2.0 at the latest, and quite possibly before a stable release. Therefore standardizing accordingly can simplify a lot of semi-duplicated APIs.

Probably the most obvious impact is the CredentialContainer and Credential.StorageId, where the latter is url-formatted and the former is not. But there's a handful of other places with similar adjustment needed.

@Firehed Firehed added this to the 1.0 milestone Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant