Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation to flag exponential notation as incorrect in pre-R4 instances #898

Closed
ewoutkramer opened this issue Mar 6, 2019 · 4 comments

Comments

@ewoutkramer
Copy link
Member

Since the parser is in a shared codebase across the FHIR DSTUs, the addition of exponential notation for decimals in R4 has caused this notation to now be accepted for pre-R4 instances too. We should look at having a specific validation for DSTU2/STU3 to catch this and flag it as an error.

@brianpos
Copy link
Collaborator

brianpos commented Mar 7, 2019

Is the Serializer (output) doing the right thing?
If so then I'd live with this. As an implementer I'd be happy to accept these coming in on the old interface, as long as they didn't go out with it.

@ewoutkramer
Copy link
Member Author

Yes, I am pretty sure it will never output exponentials - in fact our recent discussion with @kennethmyhra shows this indeed the case. Whether that's correct from the viewpoint of interop/roundtrippability is another issue...

@ewoutkramer
Copy link
Member Author

When we have split up the validator into separately configurable validation blocks, we could add a block checking for this - and then decide on running it on a per DSTU basis.

@ewoutkramer
Copy link
Member Author

We have now decided that, for the sake of sharing code, some newer features are allowed when parsing older data. Almost all of them are caught by profile validation (e.g. new enum values). This might not be, but I cannot be bothered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants