Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator does not catch invariant obs-7 #435

Closed
wmrutten opened this issue Oct 10, 2017 · 4 comments
Closed

Validator does not catch invariant obs-7 #435

wmrutten opened this issue Oct 10, 2017 · 4 comments
Labels

Comments

@wmrutten
Copy link
Contributor

Originally reported on Zulip by Jens Viladsen:

https://chat.fhir.org/#narrow/stream/implementers/subject/Profile.20Validation

"...the simplifier validator does not catch obs-7. If you state the same code in Observation.code as in Observation.component.code, where same means that both codes have the same coding (including coding.system and coding.code) - I guess that is what is meant by same"

Example:
https://simplifier.net/eSundhed2017Hackatho/Observation-example/~json#json

@brianpos
Copy link
Collaborator

The real issue here is the evaluation of != between 2 CodeableConcepts
Should that example pass, or fail?

@ewoutkramer
Copy link
Member

ewoutkramer commented Oct 23, 2017

Indeed, as per the discussion (https://chat.fhir.org/#narrow/stream/implementers/subject/Profile.20Validation/near/103391) - this is not a mistake in the .NET validator, but obs-7 is incorrect, and not easy to fix.

To progress, we need an update to the spec.

@ewoutkramer
Copy link
Member

Based on this discussion, we could make a local change to obs-7 to turn it into:

Observation.component.code.where( (coding.code = Observation.code.coding.code) and (coding.system = Observation.code.coding.system)).empty()

@marcovisserFurore
Copy link
Member

Will be fixed in R4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants