New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MFAAuthenticator Abstract #50

Open

ScopeyNZ opened this issue Nov 12, 2018 · 0 comments

Labels

affects/v3 affects/v4 change/major effort/easy impact/medium type/enhancement

Collaborator

ScopeyNZ commented Nov 12, 2018

Currently the MFAAuthenticator behaves like an abstract class but isn't an abstract. There's a comment in the leading docblock:

silverstripe-bootstrapmfa/src/Authenticators/BootstrapMFAAuthenticator.php

Line 17 in 390eae6

* It needs to be instantiable, therefore it can't be an Abstract.

It should be abstract but we'll need to identify why it "can't".

ScopeyNZ mentioned this issue

Extension hook before mfa #38

Merged

ScopeyNZ added type/enhancement affects/v3 affects/v4 change/major effort/easy impact/medium labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment