specs for :only, :except examples in activemodel validator

Changelog.md

@@ -1,5 +1,6 @@
 # UNRELEASED
 
+  * :only and :except options for CreditCardNumberValidator
   * credit card generator
   * test unit -> specs migration
   * card rules structure changed to allow custom options

lib/active_model/credit_card_number_validator.rb

@@ -1,10 +1,20 @@
 # == ActiveModel Validations CreditCardNumberValidator
 #  Can  be used in combination with the +validates+ method
 #
+#   Only Amex and Maestro
+#
 #   class CreditCard
 #     attr_accessor :number
 #     include ActiveModel::Validations
-#     validates :number, credit_card_number: {brands: [:amex, :maestro]}
+#     validates :number, credit_card_number: {only: [:amex, :maestro]}
+#   end
+#
+#   All numbers are valid except Maestro
+#
+#  class CreditCard
+#     attr_accessor :number
+#     include ActiveModel::Validations
+#     validates :number, credit_card_number: {except: [:maestro]}
 #   end
 #
 

spec/active_model_spec.rb

@@ -20,6 +20,24 @@
   end
 
 
+  describe "Except Amex and Maestro brand" do
+    it "should reject all other valid numbers" do
+      VALID_NUMBERS.except(:amex, :maestro) do |_, numbers|
+        card = model
+        card.number = numbers.first
+        card.valid?.must_equal false
+      end
+    end
+
+    it "should accept using except options" do
+      VALID_NUMBERS.except(:amex, :maestro) do |_, numbers|
+        card = model
+        card.number3 = numbers.first
+        card.valid?.must_equal true
+      end
+    end
+
+  end
 
   describe "Only Amex and Mestro brands" do
 
@@ -28,18 +46,11 @@
       VALID_NUMBERS.slice(:amex, :maestro) do |_, numbers|
         card = model
         card.number = numbers.first
+        card.number2 = numbers.first
         card.valid?.must_equal true
       end
     end
 
-    it "should reject all other valid numbers" do
-      VALID_NUMBERS.except(:amex, :maestro) do |_, numbers|
-        card = model
-        card.number = numbers.first
-        card.valid?.must_equal false
-      end
-
-    end
 
   end
 end

spec/models/credit_card.rb

@@ -1,8 +1,9 @@
 class CreditCard
-  attr_accessor :number,  :number4, :number5
+  attr_accessor :number, :number2, :number3, :number4, :number5
   include ActiveModel::Validations
   validates :number, credit_card_number: {brands: [:amex, :maestro]} , allow_blank: true
-
+  validates :number2, credit_card_number: {only: [:amex, :maestro]},  allow_blank: true
+  validates :number3, credit_card_number: {except: [:amex, :maestro]} , allow_blank: true
   validates :number4, credit_card_number: {brands: :any}  , allow_blank: true
   validates :number5, credit_card_number: true , allow_blank: true
 end