Make pip.* operation virtualenv management idempotent.

pyinfra/operations/pip.py

@@ -43,6 +43,7 @@ def virtualenv(
     if present is False:
         if host.fact.file(activate_script_path):
             yield files.directory(path, present=False, state=state, host=host)
+            host.fact._delete('file', args=(activate_script_path,))
         else:
             host.noop('virtualenv {0} does not exist'.format(path))
 
@@ -68,6 +69,12 @@ def virtualenv(
             command.append(path)
 
             yield ' '.join(command)
+
+            host.fact._create(
+                'file',
+                args=(activate_script_path,),
+                data={'user': None, 'group': None},
+            )
         else:
             host.noop('virtualenv {0} exists'.format(path))
 

tests/operations/pip.packages/add_new_virtualenv_packages.json

@@ -20,6 +20,5 @@
     "commands": [
         "virtualenv --system-site-packages testdir",
         "testdir/bin/pip install elasticquery==1.1 flask"
-    ],
-    "idempotent": false
+    ]
 }

tests/operations/pip.venv/add_virtualenv.json

@@ -10,6 +10,5 @@
     },
     "commands": [
         "python -m venv --copies /some/virtualenv"
-    ],
-    "idempotent": false
+    ]
 }

tests/operations/pip.virtualenv/add_virtualenv.json

@@ -9,6 +9,5 @@
     },
     "commands": [
         "virtualenv /some/virtualenv"
-    ],
-    "idempotent": false
+    ]
 }

tests/operations/pip.virtualenv/add_virtualenv_py3.json

@@ -10,6 +10,5 @@
     },
     "commands": [
         "virtualenv -p python3 /some/virtualenv"
-    ],
-    "idempotent": false
+    ]
 }

tests/operations/pip.virtualenv/add_with_options.json

@@ -12,6 +12,5 @@
     },
     "commands": [
         "virtualenv -p python2 --system-site-packages --always-copy /some/virtualenv"
-    ],
-    "idempotent": false
+    ]
 }

tests/operations/pip.virtualenv/present_empty_directory.json

@@ -12,6 +12,5 @@
     },
     "commands": [
         "virtualenv /some/virtualenv"
-    ],
-    "idempotent": false
+    ]
 }

tests/operations/pip.virtualenv/use_stdlib_venv.json

@@ -11,6 +11,5 @@
     },
     "commands": [
         "python -m venv --copies /some/virtualenv"
-    ],
-    "idempotent": false
+    ]
 }

tests/operations/pip.virtualenv/use_stdlib_venv_py3.json

@@ -11,6 +11,5 @@
     },
     "commands": [
         "python3 -m venv /some/virtualenv"
-    ],
-    "idempotent": false
+    ]
 }