Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support using dictionaries as hosts in Terraform connector #930

Merged
merged 3 commits into from
Jan 15, 2023

Conversation

Fizzadar
Copy link
Member

@Fizzadar Fizzadar commented Dec 17, 2022

TODO: tests

@codecov
Copy link

codecov bot commented Dec 17, 2022

Codecov Report

Merging #930 (b7a564f) into 2.x (1850b1d) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

❗ Current head b7a564f differs from pull request most recent head 1718943. Consider uploading reports for the commit 1718943 to get more accurate results

@@            Coverage Diff             @@
##              2.x     #930      +/-   ##
==========================================
- Coverage   91.60%   91.47%   -0.14%     
==========================================
  Files         124      125       +1     
  Lines        8051     8066      +15     
==========================================
+ Hits         7375     7378       +3     
- Misses        676      688      +12     
Impacted Files Coverage Δ
pyinfra/connectors/terraform.py 25.64% <0.00%> (-5.61%) ⬇️
pyinfra_cli/util.py 81.01% <0.00%> (-2.94%) ⬇️
pyinfra/api/host.py 91.52% <0.00%> (ø)
pyinfra/facts/server.py 100.00% <0.00%> (ø)
pyinfra/operations/iptables.py 100.00% <0.00%> (ø)
pyinfra/facts/util/distro.py 84.61% <0.00%> (ø)
pyinfra_cli/main.py 85.97% <0.00%> (+0.05%) ⬆️
pyinfra/api/operation.py 90.62% <0.00%> (+0.14%) ⬆️
pyinfra/connectors/ssh.py 89.96% <0.00%> (+0.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Fizzadar Fizzadar marked this pull request as ready for review December 18, 2022 11:08
@Fizzadar Fizzadar marked this pull request as draft December 31, 2022 09:45
@Fizzadar Fizzadar marked this pull request as ready for review January 15, 2023 18:06
@Fizzadar Fizzadar merged commit c4eb32a into 2.x Jan 15, 2023
@Fizzadar Fizzadar deleted the improve-terraform-connector branch January 15, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant