Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add column with test apk name in result table #1803

Closed
kozaxinan opened this issue Apr 13, 2021 · 7 comments · Fixed by #1970
Closed

Add column with test apk name in result table #1803

kozaxinan opened this issue Apr 13, 2021 · 7 comments · Fixed by #1970

Comments

@kozaxinan
Copy link
Contributor

Describe the bug

A clear and concise description of what the bug is.

21.04.1
In result table, apk name is always app-debug.apk

Screen Shot 2021-04-13 at 15 27 28

To Reproduce

Steps to reproduce the behavior:

  1. Have multimodule project
  2. Configure it with fladle
  3. run and see result table

Expected behavior

A clear and concise description of what you expected to happen.

Apk name column should show apk that used in that test run per module.

@kozaxinan kozaxinan added the Bug label Apr 13, 2021
@bootstraponline
Copy link
Contributor

The table is showing the app apk name. I agree showing the test apk instead may be more useful.

@kozaxinan
Copy link
Contributor Author

Is it possible to have different app apk? I wasnt aware of that. test-apk name would be better as table shows result of test apk.

@pawelpasterz
Copy link
Contributor

pawelpasterz commented Apr 14, 2021

Is it possible to have different app apk?

Yes, you can define app - test app pair with additional-app-test-apks

flank/test_runner/flank.yml

Lines 295 to 301 in 475a124

### Additional App/Test APKS
## Include additional app/test apk pairs in the run. Apks are unique by just filename and not by path!
## If app is omitted, then the top level app is used for that pair.
# additional-app-test-apks:
# - app: ../test_projects/android/apks/app-debug.apk
# test: ../test_projects/android/apks/app1-debug-androidTest.apk
# - test: ../test_projects/android/apks/app2-debug-androidTest.apk

Since flank supports the above feature, we can add additional column with test apk name

Changing label to feature request since it is working as designed

Dev note:

private fun TestMatrix.extractAppFileName() = testSpecification?.run {

@pawelpasterz pawelpasterz added Feature and removed Bug labels Apr 14, 2021
@pawelpasterz pawelpasterz changed the title Apk name is wrong in result table Add column with test apk name in result table Apr 14, 2021
@kozaxinan
Copy link
Contributor Author

kozaxinan commented Apr 14, 2021

I can confirm Fulladle plugin only adds app-debug to top level and doesnt add additional app to tests. https://github.com/runningcode/fladle/blob/master/fladle-plugin/src/main/java/com/osacky/flank/gradle/FulladlePlugin.kt#L73

What is the usecase for adding different app apks? Different variant support or something like that?

@bootstraponline
Copy link
Contributor

What is the usecase for adding different app apks? Different variant support or something like that?

Some companies have multiple app apks and prefer to test them as a logical group. Typical use case doesn't need this feature.

@kozaxinan
Copy link
Contributor Author

Even in that case, test apks need to have unique names. Printing test apk names would be much easier to spot which module has test fail. If using same test apk for different app is not possible, printing test apk name would be better in any case.

@bootstraponline
Copy link
Contributor

printing test apk name would be better in any case.

I agree! Thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants