Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace encrypt_password to hash_password #51

Closed
jwag956 opened this issue Apr 30, 2019 · 4 comments
Closed

replace encrypt_password to hash_password #51

jwag956 opened this issue Apr 30, 2019 · 4 comments
Labels
chore CI/CD; update packages, fix deprecation warnings, ...

Comments

@jwag956
Copy link
Member

jwag956 commented Apr 30, 2019

No description provided.

@michaelbukachi
Copy link

I'd like to take this up.

@jwag956
Copy link
Member Author

jwag956 commented May 11, 2019

You are certainly welcome to - I will review and merge as appropriate.

However (there is always a however) - I am still in the learning stage which is why I made this fork and created some releases. I am working on creating 3.1 which has almost all of the current PRs from the upstream repo. before I do that - I intend to reach out to the current maintainers and see if we can come to an agreement on moving flask-security forward. 2 independent forks isn't ideal - it would be great if we can agree early to move the main branch forward.

Bottom line - if you send a PR to my fork - it might well have to be redone in upstream if that's where it all ends up.

I am hoping to resolve all this in May...

@michaelbukachi
Copy link

Awesome. I'll work on it but I'll hold the pull request till you've finished talking with the maintainers.

@jwag956 jwag956 added the chore CI/CD; update packages, fix deprecation warnings, ... label May 26, 2019
@TillerBurr
Copy link
Collaborator

I think this issue was taken care of in #86

@jwag956 jwag956 closed this as completed Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore CI/CD; update packages, fix deprecation warnings, ...
Projects
None yet
Development

No branches or pull requests

3 participants