Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding highlight for ERB tags in html.erb files #6

Merged
merged 2 commits into from Dec 11, 2013
Merged

Adding highlight for ERB tags in html.erb files #6

merged 2 commits into from Dec 11, 2013

Conversation

Kaboofa
Copy link
Contributor

@Kaboofa Kaboofa commented Dec 8, 2013

I was frustrated that <% %> tags were not highlighted in html.erb files in Rails apps. If it fits to your colors and naming convention, feel free to merge. Regards

@maltoe
Copy link
Contributor

maltoe commented Dec 10, 2013

Hi @Kaboofa,

thanks for the pull request. Would it be possible for you to come up with colors for these scopes in the original theme (not Moonlight) as well?

thanks again.

@Kaboofa
Copy link
Contributor Author

Kaboofa commented Dec 10, 2013

Hi @maltoe,

for sure, this is done now. Happy to help.

Regards,

KaB

maltoe added a commit that referenced this pull request Dec 11, 2013
Adding highlight for ERB tags in html.erb files
@maltoe maltoe merged commit 4518691 into projectivetech:master Dec 11, 2013
@maltoe
Copy link
Contributor

maltoe commented Dec 11, 2013

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants