Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when disabling exosuit upgrades #126

Closed
wormzjl opened this issue Oct 20, 2014 · 9 comments
Closed

Crash when disabling exosuit upgrades #126

wormzjl opened this issue Oct 20, 2014 · 9 comments

Comments

@wormzjl
Copy link

wormzjl commented Oct 20, 2014

http://pastebin.com/pmpgT5vU

@elifoster
Copy link
Member

I will work on this.

@elifoster
Copy link
Member

Could not reproduce.

@wormzjl
Copy link
Author

wormzjl commented Oct 23, 2014

How to reproduce:

  1. Install an upgrade on exosuit
  2. exit and disable that upgrade in config file
  3. reenter the game

@elifoster elifoster reopened this Oct 23, 2014
@elifoster
Copy link
Member

Huh. Not really sure what I could even do about that. You're disabling something that's present in the world... That's bound to cause issues with any mod.

@wormzjl
Copy link
Author

wormzjl commented Oct 23, 2014

Perhaps just add a null check?

@dmillerw
Copy link
Contributor

I'd do a null check and log the issue. It's their fault, yes, but handling
it nicely leads to fewer complaints.
On Oct 22, 2014 11:13 PM, "wormzjl" notifications@github.com wrote:

Perhaps just add a null check?


Reply to this email directly or view it on GitHub
#126 (comment)
.

@wormzjl
Copy link
Author

wormzjl commented Oct 23, 2014

thx :D

@elifoster
Copy link
Member

I will do that tomorrow, or the day after :)

@dmillerw
Copy link
Contributor

I got bored, fixed it. Will have to commit later though.

Fun fact though, it's because the various tick handlers don't check to see if the upgrade is enabled before running. Did just need a simple null check though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Bugs
Resolved
Development

No branches or pull requests

3 participants