Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend DataSource class to better facilitate model versioning #209

Closed
Flix6x opened this issue Oct 9, 2021 · 1 comment · Fixed by #215
Closed

Extend DataSource class to better facilitate model versioning #209

Flix6x opened this issue Oct 9, 2021 · 1 comment · Fixed by #215

Comments

@Flix6x
Copy link
Contributor

Flix6x commented Oct 9, 2021

We often have new beliefs data created by some model, like a forecasting or scheduling model. Sometimes models go through different versions, sometimes they are switched out altogether. Currently, our DataSource class only facilitates keeping track of which model data comes from, by creating a new DataSource with a different name. Originally, that DataSource name was intended to name which organisation or user sourced the data. I suggest we add a little more structure to support versioned models.

Here is a suggestion:

DataSource(name=<name of organisation running model>, model=<name of function defining model>, version=<model version>)
@nhoening
Copy link
Contributor

If model and version are nullable, thus not required, I agree.

@Flix6x Flix6x linked a pull request Oct 18, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants