Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take resolution into account for maximum size of planning window #570

Closed
nhoening opened this issue Jan 1, 2023 · 1 comment · Fixed by #583
Closed

Take resolution into account for maximum size of planning window #570

nhoening opened this issue Jan 1, 2023 · 1 comment · Fixed by #583
Assignees
Labels
Milestone

Comments

@nhoening
Copy link
Contributor

nhoening commented Jan 1, 2023

The planning window (currently FLEXMEASURES_MAX_PLANNING_HORIZON) should be based on the sensor resolution, times a factor.

The number of steps for planning massively affects CPU time for computing a schedule.

We have cases where updates happen every 5 minutes, and it's okay to plan 24 hours ahead (12 * 24 = 288 steps)
Other cases have an hourly resolution, but want a week ahead (24 * 7 = 168 steps).

@nhoening nhoening added this to the 0.13.0 milestone Jan 1, 2023
@Flix6x Flix6x changed the title Take resolution into account for maximal size of planning window Take resolution into account for maximum size of planning window Jan 1, 2023
@Flix6x
Copy link
Contributor

Flix6x commented Jan 1, 2023

I suggest to repurpose FLEXMEASURES_MAX_PLANNING_HORIZON for this rather than introduce a new config setting. Based on its type, we'd have these options:

  • None: no maximum is enforced
  • int: max number of steps of the sensor's resolution
  • timedelta: max duration

@Flix6x Flix6x added the good first issue Good for newcomers label Jan 1, 2023
@Flix6x Flix6x self-assigned this Jan 11, 2023
@Flix6x Flix6x linked a pull request Jan 12, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants