Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show sensor IDs in table on asset page #1053

Merged
merged 4 commits into from
May 7, 2024
Merged

Conversation

nhoening
Copy link
Contributor

@nhoening nhoening commented May 1, 2024

Description

It can be handy to see the sensor ID of sensors when browsing the asset page. I needed this when I wanted to add a specific sensor to an asset page's sensors_to_show attribute.

Look & Feel

The sensor table on the asset page gets an extra column.

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening added the UI label May 1, 2024
@nhoening nhoening self-assigned this May 1, 2024
Copy link
Contributor

@victorgarcia98 victorgarcia98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@nhoening
Copy link
Contributor Author

nhoening commented May 2, 2024

I ran tests locally and they pass. We have an issue in the CI, but haven't been able to find out what it is.

@Flix6x Flix6x added this to the 0.21.0 milestone May 7, 2024
@Flix6x Flix6x merged commit c2d2446 into main May 7, 2024
9 checks passed
@Flix6x Flix6x deleted the ui/show-sensor-ids-on-asset-page branch May 7, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants