Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade flask-restplus to 0.9.2 #1615

Closed
arcresu opened this issue Jan 8, 2017 · 3 comments
Closed

Upgrade flask-restplus to 0.9.2 #1615

arcresu opened this issue Jan 8, 2017 · 3 comments

Comments

@arcresu
Copy link
Contributor

arcresu commented Jan 8, 2017

Currently flask-restplus is pinned at 0.8.6. Would it be possible to update this to the newest 0.9.2? Below is the relevant changelog delta.

The first breakage I see is that in noirbizarre/flask-restplus@c716cc4 (part of noirbizarre/flask-restplus#95) the Api.response method was moved to Namespace.response, and Flexget is patching this at its original location.

0.9.0 (2016-02-22)

0.9.1 (2016-04-22)

0.9.2 (2016-04-22)

  • Same version but a PyPI bug force reupload.
@liiight
Copy link
Member

liiight commented Jan 8, 2017

We have an outstanding pr in that repo that is yet to be merged. It's almost two years old now so it should probably any moment now...
Restplus project is unfortunately dead, it's dev abandoned it.
But why is this an issue to you? Api works fine with the current version.

@arcresu
Copy link
Contributor Author

arcresu commented Jan 8, 2017

I didn't notice a PR, which one did you mean? It seems like the project still has some activity though - the dev updated the contributing guidelines as recently as October.

My interest is that I'm resuming in earnest my efforts to package Flexget for Debian, starting with its dependencies. Flask-restplus is one of the dependencies which is not already in Debian and if I'm going to package it it seemed sensible to package the most recent version. However since the motivation is just to get Flexget working (for now) I can presumably get away with packaging the exact version Flexget needs.

The only actual dependency blocker I'm seeing is #1398 since Debian already has a newer version of guessit and we can't downgrade to satisfy the existing Flexget requirement there.

@liiight
Copy link
Member

liiight commented Jan 8, 2017

I invite you to look into restplus gitter to see how much it's dead, which sucks.
Anyway, this is not an issue.

@liiight liiight closed this as completed Jan 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants