Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails completely if a single translation file is missing #36

Closed
Jeehut opened this issue Oct 24, 2016 · 3 comments
Closed

Fails completely if a single translation file is missing #36

Jeehut opened this issue Oct 24, 2016 · 3 comments

Comments

@Jeehut
Copy link
Member

Jeehut commented Oct 24, 2016

BartyCrouch isn't doing anything if any of the Storyboard files is missing a translation. For example if English, Polish and Russian are specified as the projects supported languages, and there are Main.storyboard and LaunchScreen.storyboard, both base-internationalized but only for Russian and Polish, not for English, then BartyCrouch currently fails completely with "Error! No input files found." which is too general.

We could do one of the following:

  1. make BartyCrouch more resilient against missing files (so that the existing ones work)
  2. improve the error by stating that all specified project languages must be met by all IB files
  3. combine both by introducing a check for each IB file, listing the missing ones as a warning but processing the existing
@m1a7
Copy link

m1a7 commented Oct 24, 2016

Hi !
Be sure to turn the English localization into the Main.Storyboard and LaunchScreen.storyboard
zrzut ekranu 2016-10-24 o 23 45 58
zrzut ekranu 2016-10-24 o 23 48 41

@Jeehut
Copy link
Member Author

Jeehut commented May 10, 2017

Hello guys, I just released version 3.7.2 which fixes a similar issue. I didn't do any of the above changes though, but it might still have fixed this issue in it's basics (preventing BartyCrouch from crashing). As we don't have a test to reproduce this issue, I can't simply test it and have to rely on you guys instead.

Also, if anybody comes across this issue with BartyCrouch version 3.7.2 or newer again, please report this here as well (because it would mean this isn't fixed).

Thanks for your support! And sorry for having still not enough time yet to clearly fix this issue ... so many upvotes already ... 😅

@Jeehut
Copy link
Member Author

Jeehut commented May 27, 2017

I consider this fixed until somebody reports that it's not. See above comment.

@Jeehut Jeehut closed this as completed May 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants