Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tvOS Support #197

Closed
JALsnipe opened this issue Oct 5, 2017 · 17 comments
Closed

tvOS Support #197

JALsnipe opened this issue Oct 5, 2017 · 17 comments

Comments

@JALsnipe
Copy link

JALsnipe commented Oct 5, 2017

I've started looking into tvOS support, but we would have to re-write a lot of the UI as well as conditionally change things like UIStatusBar and UIAlertView usage. Has anyone else started digging into this?

@NSExceptional
Copy link
Collaborator

How would this work on a device where you can't tap views?

@DylanDuff
Copy link

Are there any chances of this coming to fruition ?

@NSExceptional
Copy link
Collaborator

NSExceptional commented Oct 17, 2018 via email

@NSExceptional
Copy link
Collaborator

Closing because @JALsnipe has not responded in over a year. I can reopen this if someone shows interest in helping make this happen.

@lechium
Copy link

lechium commented Dec 22, 2020

@NSExceptional im open to helping make this a reality on tvOS. however, im unfamiliar with the code base so i need some direction on where to start. also having an issue wrapping my head around the different UX paradigm. (siri remote and focus engine v tappable UI)

thats a tricky one to solve.

@NSExceptional
Copy link
Collaborator

Yeah, I'm not sure it makes a ton of sense to have a Select button since you can't tap on things. Maybe it would be better to disable it entirely.

I'm also not sure how a floating FLEX bar would work. How do you move it? How do you move the cursor between the bar and the app? Etc

@lechium
Copy link

lechium commented Dec 22, 2020

actually it works quite well after heavily macroing / stubbing things out. select should be disabled for sure but i think i should have a good enough initial version by end of the day with most of the rest working. sample video

@lechium
Copy link

lechium commented Dec 22, 2020

@NSExceptional in addition i have an idea for what select could be: a search menu, theres no concept of search controllers in tvOS as they exist used here. that being said select mode does partially have a place because the siri remote "just works" when moving view elements.

@lechium
Copy link

lechium commented Dec 23, 2020

i think its safe to re-open this issue: if anyone wants to follow along w/ my progress on my fork: https://github.com/lechium/FLEX

@NSExceptional NSExceptional reopened this Dec 23, 2020
@lechium
Copy link

lechium commented Dec 29, 2020

@NSExceptional @DylanDuff @JALsnipe stable tvOS release available: https://github.com/lechium/FLEX/releases/tag/4.3.0-tvOS

preview gif

the code is probably pretty close to ready for review / MR. will open one soon.

@NSExceptional
Copy link
Collaborator

I like to keep a linear commit history on the repo if we can. Do you know how to use git rebase? If not, once you get a PR ready I will need to organize the commits and get rid of that merge

@lechium
Copy link

lechium commented Jan 3, 2021

get rid of which merge? @NSExceptional not sure what you mean. im pretty familiar with rebasing, although ive never done it across forks. just different branches.

@NSExceptional
Copy link
Collaborator

This merge in the middle:

image

@lechium
Copy link

lechium commented Jan 3, 2021

@NSExceptional ahh okay that one. ill see if i can figure it out.

@lechium
Copy link

lechium commented Jan 5, 2021

@NSExceptional okay i closed my original MR and created a fresh new one from a different branch. #500
its not perfect yet but its definitely mostly full featured, very stable and very usable.

@NSExceptional
Copy link
Collaborator

Forgot to close this, but anyone looking for tvOS support should use @lechium's fork. I will be adding it to the readme.

@lechium
Copy link

lechium commented Jan 27, 2021

@NSExceptional no problem, i would definitely like to help with the refactor in any way i can if & when you get to one to make it easier to support other platforms like tvOS. please give me a heads up when you do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants