Fix black flick

[charbgr]

Suppose we have two fragments. Fragment A and Fragment B. When there is a transition between B --> A, bottomsheet flicks with a black screen causing transition seems awful.

dimView.setBackgroundColor must be set to Color.TRANSPARENT.

[ZacSweers]

Could you link a gif or screenrecord of the issue?

[charbgr]

Sure! Check this out! https://www.youtube.com/watch?v=2BzbmDg6Nxo at 0:13.

Sometimes doesn't flick.. :/

[ZacSweers]

That video's with or without the proposed fix?

[charbgr]

without

2015-07-25 7:49 GMT+03:00 Henri (Zac) Sweers notifications@github.com:

That video's with or without the proposed fix?

—
Reply to this email directly or view it on GitHub
#23 (comment).

[SamThompson]

I agree this is a bug, but we can't set dimView to be transparent because we would lose the dimming effect. The black screen no longer showed up probably because by making dimView transparent, it was effectively being hidden from view.

[charbgr]

So, what if we change this dynamically?

[SamThompson]

Could you supply a code example of the bug? We're having trouble reproducing it.

[charbgr]

git clone git@bitbucket.org:charbgr/bottomsheet-black_flick.git

[ZacSweers]

Get a permission denied error when trying to clone :/

On Fri, Jul 31, 2015 at 3:22 AM Basilis Charalampakis <
notifications@github.com> wrote:

git clone git@bitbucket.org:charbgr/bottomsheet-black_flick.git

—
Reply to this email directly or view it on GitHub
#23 (comment).

[charbgr]

Its not private.. try htts : git clone
https://charbgr@bitbucket.org/charbgr/bottomsheet-black_flick.git

2015-08-02 1:44 GMT+03:00 Henri (Zac) Sweers notifications@github.com:

Get a permission denied error when trying to clone :/

On Fri, Jul 31, 2015 at 3:22 AM Basilis Charalampakis <
notifications@github.com> wrote:

git clone git@bitbucket.org:charbgr/bottomsheet-black_flick.git

—
Reply to this email directly or view it on GitHub
<#23 (comment)
.

—
Reply to this email directly or view it on GitHub
#23 (comment).

[ZacSweers]

That worked. Looking at it now though, I see that you're using a bottomsheet in the rootview for your fragment but not you're activity. To be honest, I'm not sure that's a case we want to support. Bottomsheet is supposed to be relative to the entire content view, and it would be weird (in my opinion) to show it in smaller containers on the screen. The material spec doesn't show any examples of this either. We have some upcoming changes that also assume that it's relative to the entire screen, so for the forseeable future I think it's best to stick with it on a per-activity basis.

Testing your sample code, I was able to remove the issue after moving it to the main activity layout. Here's a patch file of the changes if you want to apply and test yourself.

If you absolutely need to be able to do this on a per-fragment basis, I'd rather the pull request tune parts of BottomSheetLayout that would allow you to extend and override this behavior locally. What do you think?

[ZacSweers]

Going to close this for now