Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add window duration property in aggregated profile proto (header) #62

Open
anvinjain opened this issue Mar 14, 2017 · 0 comments
Open

Comments

@anvinjain
Copy link

There can be clock skew on backend machine resulting in start time and end time not being accurate values. Since we are depending on vertx timer for expiry of aggregation window(which uses stable clock), we know that expiry will happen correctly regardless of wall clock skew. So, additionally capturing duration of window in java objects. This needs to be added as a new field and serialized in aggregated profile proto as well.

Changes in aggregation window were made in this commit: a525979

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants