New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/tertiary button #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a little point to discuss I think but this is really clean. Do you want to implement small and large size on DSFRSizes and DSFRTypographie befoire merging this?
It's not needed to implement inside this MR, the integration of different sizes will be part of a larger refacto so I think it is ok for now to merge only the code related to the feature implied by the branch. |
DSFRTertiaryButton
(specs)DSFRPrimaryButton
,DSFRSecondaryButton
&DSFRTertiaryButton
DSFRColors.copyWith
as those colors should never be changed to a different value than the base light & dark variant (specs)