Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/tertiary button #2

Merged
merged 12 commits into from Jul 7, 2022
Merged

Feat/tertiary button #2

merged 12 commits into from Jul 7, 2022

Conversation

TesteurManiak
Copy link
Member

  • Added DSFRTertiaryButton (specs)
  • Added "icon only" variant to base buttons (specs)
  • Added "disabled state" to base buttons (specs)
  • Golden tests for light and dark variant of DSFRPrimaryButton, DSFRSecondaryButton & DSFRTertiaryButton
  • Removed params in DSFRColors.copyWith as those colors should never be changed to a different value than the base light & dark variant (specs)

@TesteurManiak TesteurManiak added the enhancement New feature or request label Jul 7, 2022
@TesteurManiak TesteurManiak self-assigned this Jul 7, 2022
Copy link
Member

@Pierre-Monier Pierre-Monier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a little point to discuss I think but this is really clean. Do you want to implement small and large size on DSFRSizes and DSFRTypographie befoire merging this?

@TesteurManiak
Copy link
Member Author

just a little point to discuss I think but this is really clean. Do you want to implement small and large size on DSFRSizes and DSFRTypographie befoire merging this?

It's not needed to implement inside this MR, the integration of different sizes will be part of a larger refacto so I think it is ok for now to merge only the code related to the feature implied by the branch.

@TesteurManiak TesteurManiak merged commit 279a252 into main Jul 7, 2022
@TesteurManiak TesteurManiak deleted the feat/tertiary_button branch July 7, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants