Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Healthcheck failed since FF deps removed in 1.0 #61

Closed
flecoufle opened this issue Dec 3, 2022 · 0 comments · Fixed by #62
Closed

Healthcheck failed since FF deps removed in 1.0 #61

flecoufle opened this issue Dec 3, 2022 · 0 comments · Fixed by #62
Labels
needs-triage Needs looking at to decide what to do

Comments

@flecoufle
Copy link
Contributor

Current Behavior

return code not equal 0 in

$ node /healthcheck.js 
node:internal/modules/cjs/loader:936
  throw err;
  ^

Error: Cannot find module '@flowforge/nr-auth'
Require stack:
- /data/settings.js
- /healthcheck.js
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
    at Function.Module._load (node:internal/modules/cjs/loader:778:27)
    at Module.req
- /healthcheck.js
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
    at Function.Module._load (node:internal/modules/cjs/loader:778:27)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/data/suire (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/data/settings.js:5:16)
    at Module._compile (node:internal/modules/cjs/loader:1105:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:1005:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [ '/data/settings.js', '/healthcheck.js' ]
}

so containers are flagged "unhealthy"

Expected Behavior

script in success (or disable healhcheck)

this is caused by removing FF nodes in commit ba74519

I have worked arounded (not sustainable) by changing all "@flowforge/..." by absolute path in /data/settings.js
unfortunately I can't create a PR to fix it properly (perhaps multiples solutions to fix this issue)

workaround example:
require('@flowforge/nr-auth') into require('/usr/src/flowforge-nr-launcher/node_modules/@flowforge/nr-auth')

dependencies in /data/settings.js:

  • nr-auth
  • nr-storage
  • nr-audit-logger

Steps To Reproduce

with a FF-NR image >= 1.0 build

  1. start a project
  2. container is unhealthy

Environment

  • FlowForge version: 1.1
  • Node.js version: v16.16.0
  • npm version: 8.11.0
  • Platform/OS: armv7
  • Browser: not revelant
  • FF/docker-compose >= 1.0
@flecoufle flecoufle added the needs-triage Needs looking at to decide what to do label Dec 3, 2022
This was referenced Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Needs looking at to decide what to do
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant