Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is possible to get a project status stuck in an intermediate state #1232

Closed
Steve-Mcl opened this issue Nov 16, 2022 · 5 comments · Fixed by #1539, FlowFuse/nr-launcher#94 or #1559
Closed
Assignees
Labels
area:frontend For any issues that require work in the frontend/UI bug Something isn't working priority:medium Medium Priority
Milestone

Comments

@Steve-Mcl
Copy link
Contributor

Current Behavior

Related to "Difficulty editing project settings when project state is intermediate" #1231 where the settings page was effectively unusable due to status refreshing...

It is possible to get a project stuck on an intermediate state e.g. not stopped/not suspended/not started.

Other notes...
  • For the short time my environment was in this state (approx 10 mins) the out.log was littered with around 650 lines containing the following repeated pattern...
Loading project settings
Target state is 'running'
Starting Node-RED
/** snipped for brevity **/
Loading project settings
Target state is 'running'
Starting Node-RED

Expected Behavior

Unsure - perhpas there should be a specific state like "Stalled"?

Steps To Reproduce

  1. Stop a project
  2. Edit the project settings and add a non-existing NPM package to the packages table
  3. Save settings
  4. Start the project

Environment

  • FlowForge version: 1.0.3-git
@Steve-Mcl Steve-Mcl added the needs-triage Needs looking at to decide what to do label Nov 16, 2022
@knolleary knolleary added this to the 1.1 milestone Nov 16, 2022
@knolleary knolleary added bug Something isn't working area:frontend For any issues that require work in the frontend/UI priority:medium Medium Priority labels Nov 24, 2022
@knolleary knolleary modified the milestones: 1.1, 1.2 Nov 24, 2022
@knolleary knolleary removed the needs-triage Needs looking at to decide what to do label Nov 24, 2022
@Steve-Mcl Steve-Mcl self-assigned this Dec 13, 2022
@ZJvandeWeg ZJvandeWeg modified the milestones: 1.2, 1.3 Dec 22, 2022
@Steve-Mcl Steve-Mcl linked a pull request Jan 11, 2023 that will close this issue
2 tasks
@Steve-Mcl Steve-Mcl linked a pull request Jan 11, 2023 that will close this issue
1 task
@Steve-Mcl
Copy link
Contributor Author

@hardillb

I would appreciate you testing the PRs for this issue in docker/k8s env if you can?

Steps to test before this PR...

  1. Stop a project
  2. Edit the project settings and add a non-existing NPM package to the packages table
  3. Save settings
  4. Start the project
    1. Expect to see state stuck at "installing"

Steps to test after PR is applied...

  1. Stop a project
  2. Edit the project settings and add a non-existing NPM package to the packages table
  3. Save settings
  4. Start the project
    1. Expect to see state return to stopped
    2. Expect to see events updated in the "Recent Activity"
  5. In the action menu, try to start/restart
    1. Expect to see state return to stopped
    2. Expect to see events updated in the "Recent Activity"

@hardillb
Copy link
Contributor

Works on K8s

@hardillb
Copy link
Contributor

Works on docker

@hardillb
Copy link
Contributor

@Steve-Mcl Only problem is that the page doesn't stop polling when it enters Stopped state so you can't edit the settings again until you reload the page.

@Steve-Mcl
Copy link
Contributor Author

Tested in both staging an latest git ...

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend For any issues that require work in the frontend/UI bug Something isn't working priority:medium Medium Priority
Projects
Archived in project
4 participants