Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not remove/add project from billing when updating stack #1598

Closed
1 task
knolleary opened this issue Jan 19, 2023 · 2 comments · Fixed by #1642
Closed
1 task

Do not remove/add project from billing when updating stack #1598

knolleary opened this issue Jan 19, 2023 · 2 comments · Fixed by #1642
Assignees
Labels
area:billing Anything related to Stripe integration size:S - 2 Sizing estimation point story A user-oriented description of a feature
Milestone

Comments

@knolleary
Copy link
Member

knolleary commented Jan 19, 2023

Description

As a: user

I want to: update my project stack without being invoiced

So that: I don't get multiple invoices when performing basic admin tasks on my projects


Under the covers, our implementation of updating a project stack involves:

  • suspending the project
  • changing the stack pointer
  • starting the project

When billing is enabled, the suspend step causes us to remove the project from the team subscription on stripe. It then gets re-added when the project is restarted.

This triggers invoices from Stripe which is unexpected for the user and may lead them to think they are being charged extra/incorrectly etc.

Whilst it is correct to remove the project from stripe when the project is suspended, there are cases like this where we know the project will be resumed immediately. As such, we should pass in a flag to the suspend call to say this is a 'temporary' suspend. The billing logic can then use that flag to skip removing from the subscription.

We also need to be able to resume the project without having it readd to stripe - we don't want to end up double charging. Whether it this is done by a similar flag passed to the start call, or if we need to track the state more persistently, I'm not sure without stepping through the logic we currently have.

Which customers would this be availble to

All

Acceptance Criteria

  • Can update project stack without interfering with billing
@knolleary knolleary added story A user-oriented description of a feature size:S - 2 Sizing estimation point area:billing Anything related to Stripe integration labels Jan 19, 2023
@knolleary knolleary added this to the 1.4 milestone Jan 20, 2023
This was referenced Jan 25, 2023
@Pezmc Pezmc self-assigned this Jan 26, 2023
@Pezmc
Copy link
Contributor

Pezmc commented Jan 27, 2023

This is working on https://github.com/flowforge/flowforge/tree/feat-1598-stack-change-without-billing but will conflict with #1610 so am addressing that first.

@Pezmc
Copy link
Contributor

Pezmc commented Feb 7, 2023

This is now deployed to staging and ready to be verified there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:billing Anything related to Stripe integration size:S - 2 Sizing estimation point story A user-oriented description of a feature
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants