Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a preview of Team Library entries on click #1657

Closed
Tracked by #1597
joepavitt opened this issue Feb 3, 2023 · 4 comments · Fixed by #1672
Closed
Tracked by #1597

Show a preview of Team Library entries on click #1657

joepavitt opened this issue Feb 3, 2023 · 4 comments · Fixed by #1672
Assignees
Labels
area:frontend For any issues that require work in the frontend/UI size:S - 2 Sizing estimation point task A piece of work that isn't necessarily tied to a specific Epic or Story.
Milestone

Comments

@joepavitt
Copy link
Contributor

joepavitt commented Feb 3, 2023

Currently, it is not possible to click on any of the .json or .js files in a Team's library. This task will enable that, and then show a preview of it's content in the team Library UI.

@joepavitt joepavitt mentioned this issue Feb 3, 2023
7 tasks
@joepavitt joepavitt changed the title Show a preview of entries on click Show a preview of Team Library entries on click Feb 3, 2023
@joepavitt joepavitt self-assigned this Feb 3, 2023
@joepavitt joepavitt added this to the 1.4 milestone Feb 3, 2023
@joepavitt joepavitt added task A piece of work that isn't necessarily tied to a specific Epic or Story. size:S - 2 Sizing estimation point area:frontend For any issues that require work in the frontend/UI labels Feb 3, 2023
@joepavitt
Copy link
Contributor Author

Not sure which way to go in terms of layout/interaction:

Screenshot 2023-02-03 at 16 33 34

Option 1 - New Page

  • Gives clean separation, easier to build, and navigate to straight from URL.
  • Scales the best to mobile too

Option 2 - Dialog

  • More "preview"-y than Option 1,
  • Doesn't scale well

Option 3 - Bottom

  • More "preview"-y than Option 1
  • Easy to switch to another file in a single click, rather than having to go "back"
  • Doesn't scale great when we have lots of content in a single folder

Option 4 - Side

  • More "preview"-y than Option 1
  • Easy to switch to another file in a single click, rather than having to go "back"
  • May have to switch to Option 3 on smaller screens

@joepavitt
Copy link
Contributor Author

option 1 implemented for starters:

Screen.Recording.2023-02-03.at.17.11.08.mov

@ZJvandeWeg
Copy link
Member

If the flow isn't rendered, why would we pursue this?

@joepavitt
Copy link
Contributor Author

Because its not just flow.json files they can save.

Also possible to save function.js files, which are useful to inspect. Having flows here also makes them easier to export outside of flowforge, as no need to open Node-RED to get them.

Very easy win here, was only 1 hr of work, just need to add some styling/syntax highlighting to it.

Iteration towards then showing the flow eventually, but that's a big piece of work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend For any issues that require work in the frontend/UI size:S - 2 Sizing estimation point task A piece of work that isn't necessarily tied to a specific Epic or Story.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants