Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I can't promote a NR instance through the DevOps Pipeline #2363

Closed
robmarcer opened this issue Jun 29, 2023 · 11 comments · Fixed by #2384
Closed

I can't promote a NR instance through the DevOps Pipeline #2363

robmarcer opened this issue Jun 29, 2023 · 11 comments · Fixed by #2384
Assignees
Labels
bug Something isn't working priority:high High Priority
Milestone

Comments

@robmarcer
Copy link
Contributor

robmarcer commented Jun 29, 2023

Current Behavior

When I try to promote the content of an instance to the next stage of the DevOps pipeline I get an error 'Request Failed: Not Found'.

I wondered if the issue was that the stack I was promoting to was older than the source but I am still getting the same error after getting them both on the same stack.

Expected Behavior

I should be able to promote the instance onto the next stage.

Steps To Reproduce

I took a pre-existing instance, added it to the first stage of a DevOps pipeline.

Created a new instance, added it to the second stage of the pipeline.

Tried to promote from one to the next.

This video shows the exact steps. https://d.pr/v/iz8WrQ

Environment

  • FlowForge version: 1.8
  • Node.js version: 16.20.0
  • npm version: Current
  • Platform/OS: Mac current
  • Browser: Chrome current

Have you provided an initial effort estimate for this issue?

I can not provide an initial effort estimate

@robmarcer robmarcer added the needs-triage Needs looking at to decide what to do label Jun 29, 2023
@MarianRaphael MarianRaphael added bug Something isn't working and removed needs-triage Needs looking at to decide what to do labels Jun 29, 2023
@MarianRaphael MarianRaphael added this to the 1.10 milestone Jun 30, 2023
@robmarcer
Copy link
Contributor Author

This bug was also reported by a FF user on 1st July via the FF live chat tool.

@knolleary
Copy link
Member

@robmarcer please can you provide details of your instance so we can investigate?

@robmarcer
Copy link
Contributor Author

@knolleary in the 'FlowForge Team' on FF Cloud, application 'Customer Success', DevOps pipeline 'CS'.

I am trying to move production (main) to dev (dev) first so I can then reverse the pipeline and work on dev going forward. Each time I try to promote I get the error.

Source instance - https://d.pr/i/rcy2wo
Target instance - https://d.pr/i/h5Gi6c

Let me know if you need any more details.

@robmarcer
Copy link
Contributor Author

This is becoming a blocker for me, I can't get it to work at all (I've tried on three different teams). If anyone has any work-arounds that would be really appreciated as I can't demo the pipeline to customers / sales. @MarianRaphael @knolleary

@MarianRaphael MarianRaphael added the priority:high High Priority label Jul 3, 2023
@knolleary
Copy link
Member

Clicking the promote button on the stage generates this error on the browser console:

GET https://app.flowforge.com/api/v1/pipelines/rLV3DM0Jm4/stages/undefined 404

That undefined looks very wrong...

@knolleary knolleary self-assigned this Jul 3, 2023
@knolleary knolleary modified the milestones: 1.10, 1.9 Jul 3, 2023
@MarianRaphael
Copy link
Contributor

MarianRaphael commented Jul 3, 2023

I am having the same problems with these two instances. It's also weird that they switch positions in the pipeline.

Bug-recording.mp4

@knolleary
Copy link
Member

The issue is related to the fact the pipeline UI is presenting the stages in the wrong order. The second stage is being displayed as the first stage in the pipeline. So when you click the 'promote' button, it is trying to promote the second stage to its target - but it doesn't have one.

What I do not currently know is why it is presenting them the wrong way around. My local environment, running the 1.8 code, does not do this (and clearly, wouldn't have passed any of the testing we did if this was systemic).

@knolleary
Copy link
Member

I can see the UI is presenting the stages in the order they are provided by the API response. For some reason, they are out of order for this particular application. But not for others.

The UI ought to be able to validate the order, as each stage should have a 'NextStageId' property (except for the final stage in the pipeline). Equally, the API ought to be providing them in the right order.

@knolleary
Copy link
Member

Issue closed as the fix has been merged to main. We will get this rolled out to production today - I will confirm back here when that is done.

@knolleary
Copy link
Member

@robmarcer the fix is now in production. I have had a quick look and I can see your pipeline has its stages in the right order now. I have not clicked the 'promote' button in your instance, but please do so and confirm its working for you.

@robmarcer
Copy link
Contributor Author

Thanks @knolleary @Pezmc @MarianRaphael, it's working correct for me now. I'll let the customer know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:high High Priority
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants