Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation Restructure #2474

Closed
joepavitt opened this issue Jul 12, 2023 · 6 comments · Fixed by #2560
Closed

Navigation Restructure #2474

joepavitt opened this issue Jul 12, 2023 · 6 comments · Fixed by #2560
Labels
area:frontend For any issues that require work in the frontend/UI epic A significant feature or piece of work that doesn't easily fit into a single release size:M - 3 Sizing estimation point
Milestone
1.11

Comments

@joepavitt
Copy link
Contributor

Description

Getting consistent feedback that the nested left-side navigation is not clear. As such, we are looking to re-work the navigation to have primary left-nav, with secondary tabbed navigation at the Instance/Application/Device level. This is actually more consistent with what we had in FlowForge < v0.5.0

Screenshot 2023-07-12 at 10 07 45 Screenshot 2023-07-12 at 10 07 50
@joepavitt joepavitt added the epic A significant feature or piece of work that doesn't easily fit into a single release label Jul 12, 2023
@joepavitt
Copy link
Contributor Author

May pair well with #2334 @MarianRaphael

@joepavitt
Copy link
Contributor Author

@ZJvandeWeg @zackwasli fyi - based on your experience/feedback from Monday

@ZJvandeWeg
Copy link
Member

@joepavitt In the second screenshot, should the "Instances" breadcrumb maybe be the application name? And when you click on it, it'll show you the application?

@joepavitt
Copy link
Contributor Author

In the second screenshot, should the "Instances" breadcrumb maybe be the application name? And when you click on it, it'll show you the application?

I had considered this, but if you're navigating to an Instance from the "Instances" page, then having a breadcrumb parent of a different page all together does feel a bit odd.

Similarly, for the "Device" - should that also be nested within an Application (if it is attached to one)? I want to try and start treating Instances/Devices as "equals" where possible.

@joepavitt
Copy link
Contributor Author

My approach was to have the "Application: Application Name" underneath the breadcrumb, which is a link and clcikable

@joepavitt joepavitt mentioned this issue Jul 13, 2023
Closed
4 tasks
@joepavitt joepavitt added size:M - 3 Sizing estimation point area:frontend For any issues that require work in the frontend/UI labels Aug 1, 2023
@MarianRaphael MarianRaphael linked a pull request Aug 11, 2023 that will close this issue
Re-Work FF Navigation #2560
Merged
11 tasks
@MarianRaphael MarianRaphael added this to the 1.11 milestone Aug 11, 2023
@MarianRaphael
Copy link
Contributor

See "Bug": #2620

@MarianRaphael MarianRaphael mentioned this issue Aug 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:frontend For any issues that require work in the frontend/UI epic A significant feature or piece of work that doesn't easily fit into a single release size:M - 3 Sizing estimation point
Projects
🛠 Development
Archived in project
Milestone
1.11
Development

Successfully merging a pull request may close this issue.

Re-Work FF Navigation FlowFuse/flowfuse
3 participants
@ZJvandeWeg @MarianRaphael @joepavitt