Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow Viewer: Snapshots #3798

Closed
3 of 4 tasks
Tracked by #3623
joepavitt opened this issue Apr 30, 2024 · 7 comments · Fixed by #3835 or #3846
Closed
3 of 4 tasks
Tracked by #3623

Flow Viewer: Snapshots #3798

joepavitt opened this issue Apr 30, 2024 · 7 comments · Fixed by #3835 or #3846
Assignees
Labels
area:frontend For any issues that require work in the frontend/UI headline Something to highlight in the release size:L - 5 Sizing estimation point task A piece of work that isn't necessarily tied to a specific Epic or Story.
Milestone

Comments

@joepavitt
Copy link
Contributor

joepavitt commented Apr 30, 2024

Implement the https://github.com/FlowFuse/flow-renderer in the FF product, by adding the option to visualise any Snapshots.

Design for the modal viewer for the flows themselves available here: #3768 although need to add the specifics of accessing/opening this from the "Snapshots" view.

@joepavitt joepavitt added size:S - 2 Sizing estimation point area:frontend For any issues that require work in the frontend/UI task A piece of work that isn't necessarily tied to a specific Epic or Story. labels Apr 30, 2024
@joepavitt joepavitt self-assigned this May 1, 2024
@joepavitt
Copy link
Contributor Author

Switching to #3803 as first iteration as the APIs for Snapshots are a little more complicated than we need. The only way of getting the flow.json equiavelent would be using /export API end point, which is excessive for what we need here. As such, a new /flow endpoint (or something similar) should be built to better enable this viewer for snapshots

@joepavitt joepavitt removed their assignment May 1, 2024
@ZJvandeWeg
Copy link
Member

Interesting comment, I was going to ask what the design is for showing env vars, NR version, etc etc. :) Team library might indeed be a quicker win

@joepavitt
Copy link
Contributor Author

I was going to ask what the design is for showing env vars, NR version, etc etc

Iteration, iteration, iteration :)

@Steve-Mcl
Copy link
Contributor

Steve-Mcl commented May 3, 2024

Design for the modal viewer for the flows themselves available here: #3768 although need to add the specifics of accessing/opening this from the "Snapshots" view.

In a first iteration, there are 2 relatively basic approaches:

  1. The snapshot tables kebab menu gets a new option "View Snapshot"
    1. NOTE: not all snapshot tables have the kebab menu so would need to be added (Applications, Devices)
    2. Related: Add appropriate Snapshot actions to all snapshot table views #3815
  2. The tables get a new slim column with only a button 👁️

NB: Since #3815 will require the snapshot tables to have a kebab menu, I would favour option 1.

What is not explicitly mentioned is who can view it but since the "Download Snapshot" #3627 feature is scoped to "Member", that would be a starting point.

@joepavitt joepavitt added size:L - 5 Sizing estimation point and removed size:S - 2 Sizing estimation point labels May 7, 2024
This was referenced May 7, 2024
@Steve-Mcl Steve-Mcl linked a pull request May 8, 2024 that will close this issue
12 tasks
@joepavitt joepavitt added the headline Something to highlight in the release label May 8, 2024
@Steve-Mcl
Copy link
Contributor

re-open for 2 follow on issues in the task list

@Steve-Mcl Steve-Mcl reopened this May 8, 2024
@joepavitt joepavitt modified the milestones: 2.5, 2.4 May 8, 2024
@joepavitt
Copy link
Contributor Author

Keeping this in the "Review" column to make sure we don't lose track of it

@joepavitt
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend For any issues that require work in the frontend/UI headline Something to highlight in the release size:L - 5 Sizing estimation point task A piece of work that isn't necessarily tied to a specific Epic or Story.
Projects
Status: Done
3 participants