Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users with accounts should be able to try out existing blueprints by using a configured URL #3973

Closed
Tracked by #3946
cstns opened this issue Jun 3, 2024 · 9 comments · Fixed by #3994
Closed
Tracked by #3946
Assignees
Labels
area:frontend For any issues that require work in the frontend/UI size:S - 2 Sizing estimation point
Milestone

Comments

@cstns
Copy link
Contributor

cstns commented Jun 3, 2024

Authenticated users should be able to access a url that contains the blueprint id and be taken to an instance creation form.

The url format:
<FlowFuse.domain>/deploy/blueprint?blueprintId=<xxx>

At this moment in time the user's default team will be used and the user will have the option to select the application where the new instance will be created

The landing page is implemented as a distinct page which allows for greater flexibility in the sense that we could integrate gtag tags when reaching this stage.

@cstns cstns self-assigned this Jun 3, 2024
@cstns cstns added area:frontend For any issues that require work in the frontend/UI size:S - 2 Sizing estimation point labels Jun 3, 2024
@cstns
Copy link
Contributor Author

cstns commented Jun 7, 2024

Incidentally, this implementation would also work for unauthenticated users that attempt to access the url because they would get automatically redirected to the landing page.

@cstns
Copy link
Contributor Author

cstns commented Jun 10, 2024

Should users that belong to teams that don't have the Library feature enabled be allowed to 'deploy' instances via URL?

At the moment we're using the user's default team or the first team available if a user doesn't have a default team configured, but this team might not have the Team Library feature enabled.

A couple of ways of moving forward would be to:

  • have a dialog prompt on the Blueprint landing page that would allow users to select from a list of teams that do support the Team Library feature (if the user is part of any)
  • If no such teams are available, display a notice that a team upgrade might be required or similar
  • let the user deploy the blueprint (would actually bypass the Team Library feature)

@hardillb @knolleary thoughts?

@knolleary
Copy link
Member

@cstns Team Library and Blueprints are two different feature sets. We allow starter teams to use blueprints, even though they don't have the Team Library feature available to them.

@knolleary
Copy link
Member

Okay - I take that back. I thought blueprints were available to starter teams, but that doesn't appear to be the case... I need to double check that.

@cstns
Copy link
Contributor Author

cstns commented Jun 10, 2024

I thought I might have configured local poorly because as a user belonging to a team that doesn't have the Team Library enabled he's just prompted with an upgrade banner when accessing the Library page.

In that case, another option would be to enable blueprints for everyone but that would be a business decision, if the above config is correct.

@knolleary
Copy link
Member

In that case, another option would be to enable blueprints for everyone but that would be a business decision, if the above config is correct.

I thought they were already enabled for everyone. I'm trying to work out if I'm misremembering that, or if something has changed that should not have changed.

@knolleary
Copy link
Member

Okay - got to the bottom of it. I was looking at the wrong thing.

  1. Blueprints are available to all Team Types
  2. The Team Library feature is a separate feature
  3. When we added the blueprint tab to the TEam Library page, it should not be blocking access based on the Team Library feature flag - only the Team Library tab should be doing that.

@cstns
Copy link
Contributor Author

cstns commented Jun 10, 2024

I found the PR change that added that feature, it was my doing, I might have mirrored the library feature too much.

I'll create another PR to address it.

@knolleary
Copy link
Member

@cstns #4004 ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend For any issues that require work in the frontend/UI size:S - 2 Sizing estimation point
Projects
Status: Closed / Done
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants