Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom 503 Page #892

Open
sammachin opened this issue Aug 15, 2022 · 8 comments
Open

Custom 503 Page #892

sammachin opened this issue Aug 15, 2022 · 8 comments
Assignees
Labels
area:frontend For any issues that require work in the frontend/UI priority:low Low Priority size:M - 3 Sizing estimation point task A piece of work that isn't necessarily tied to a specific Epic or Story.

Comments

@sammachin
Copy link
Contributor

sammachin commented Aug 15, 2022

Description

If a project is not running flowforge returns a 503 response.
Currently this is a generic server page, and is only seen in the short window when a project re updated such as a stack change.

With the introduction of suspended projects #377 this will be the response that is sent for a project that has been suspended, as such we should have something branded and explanatory with a link to flowforge.com

Suggested Copy:
This project is not currently running, login to your FlowForge application and check the status of the project, or contact the owner

Project UI should be fully stand alone and is not part of either the forge application or the website.

Epic/Story

No response

@sammachin sammachin added task A piece of work that isn't necessarily tied to a specific Epic or Story. area:frontend For any issues that require work in the frontend/UI labels Aug 15, 2022
@sammachin sammachin added this to the 0.9 milestone Aug 22, 2022
@sammachin sammachin modified the milestones: 0.9, 1.0 Sep 1, 2022
@ArshErgon
Copy link
Contributor

I think vue-route will help here, we can create a custom 503 page or for future we can also 404 page, and we can redirect the user to our custom page, something like this

if (response.status == 503) {
   return custom_503_handler

but can recreate 503 error in development?

@hardillb
Copy link
Contributor

@ArshErgon This is not for the Forge App, this is for the individual FF Projects (instances of Node-RED). This can not be fixed in the Vue code, it needs to be handled by the reverse proxy that routes to them on the Docker and K8s versions of the platform.

@hardillb hardillb self-assigned this Sep 14, 2022
@hardillb
Copy link
Contributor

Struggling with this one at the moment.

I've found something that looks like it might work with the nginx ingress controller (https://kubernetes.github.io/ingress-nginx/examples/customization/custom-errors/) but that won't work on AWS because that uses the AWS ALB ingress controller.

It feels like there should be an annotation but I can't find one in the docs, https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.4/guide/ingress/annotations/#actions looked promising but that looks to only override the normal response from the project.

@hardillb
Copy link
Contributor

Will document how to do this with NGIX and try and find some help at the Kubehuddle for AWS

@sammachin sammachin modified the milestones: 0.10, 1.0 Sep 29, 2022
@knolleary knolleary modified the milestones: 1.0, 1.1 Oct 28, 2022
@knolleary knolleary modified the milestones: 1.1, 1.2 Nov 24, 2022
@knolleary knolleary added the size:M - 3 Sizing estimation point label Nov 25, 2022
@ZJvandeWeg ZJvandeWeg added the priority:low Low Priority label Nov 29, 2022
@hardillb
Copy link
Contributor

@ZJvandeWeg
Copy link
Member

@hardillb Should we move this issue back to the backlog?

@hardillb
Copy link
Contributor

@ZJvandeWeg yes

@hardillb
Copy link
Contributor

This will also get much easier to do if we move to nginx ingres from AWS ALB ingress

@ZJvandeWeg ZJvandeWeg removed this from the 1.2 milestone Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend For any issues that require work in the frontend/UI priority:low Low Priority size:M - 3 Sizing estimation point task A piece of work that isn't necessarily tied to a specific Epic or Story.
Projects
None yet
Development

No branches or pull requests

5 participants