Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No feedback when an API error occurs editing user #966

Closed
Steve-Mcl opened this issue Sep 9, 2022 · 2 comments · Fixed by #967
Closed

No feedback when an API error occurs editing user #966

Steve-Mcl opened this issue Sep 9, 2022 · 2 comments · Fixed by #967
Labels
area:frontend For any issues that require work in the frontend/UI bug Something isn't working
Milestone

Comments

@Steve-Mcl
Copy link
Contributor

Current Behavior

Server-side validation errors are not shown to admin user

Demo show where an attempt to change the name of user test5 to user4 - note user4 already exists but no error is show.

chrome_FyITRIblTL

The same issue is present for API errors

  • "Invalid username"
  • "email must be unique"
  • unknown errors

Expected Behavior

Dialog to remain open and to inform user of issue via the validation text

NOTE: the validation text is already present but is impossible to show since the ff-dialog closes upon confirm regardless of the API call success

Related: FlowFuse/forge-ui-components#48

Steps To Reproduce

with 3 users named admin1 (admin) & user1 user2 (non admin)...

  1. login as admin1
  2. edit user1
  3. set user1 name to user2

dialog is dismissed and no change has occured.

Environment

  • FlowForge version: 0.9.0-git
  • Node.js version: NA
  • npm version: NA
  • Platform/OS: All
  • Browser: All
@Steve-Mcl
Copy link
Contributor Author

@knolleary @hardillb as a non admin on staging, I cannot check this - would one of you be kind enough to verify this pls?

@hardillb
Copy link
Contributor

I now see a error text under the username if trying to change it to an existing user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend For any issues that require work in the frontend/UI bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants