Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting :rows-selectable="true" on ff-data-table breaks kebab menu #58

Closed
Steve-Mcl opened this issue Oct 13, 2022 · 1 comment · Fixed by #66
Closed

Setting :rows-selectable="true" on ff-data-table breaks kebab menu #58

Steve-Mcl opened this issue Oct 13, 2022 · 1 comment · Fixed by #66
Assignees
@Pezmc @joepavitt
Labels
area:frontend For any issues that require work in the frontend/UI bug Something isn't working good first issue Good for newcomers size:S - 2 Sizing estimation point
Milestone
1.0

Comments

@Steve-Mcl
Copy link
Contributor

Current Behavior

chrome_cV5ONeOmpT

Clicking the kebab menu on a table results in the @row-selected event being fired.

Expected Behavior

Show the kebab menu and inhibit the @row-selected event

Steps To Reproduce

  • Add a ff-data-table with items
  • Set :rows-selectable="true" @row-selected="editRow"
  • in method editRow navigate to another view (e.g. this.$router.push({name: 'MyEditor', params: { id: row.id }))

Environment

  • FlowForge version: 0.10.0-git
  • Platform/OS: Windows
  • Browser: Chrome
@Steve-Mcl Steve-Mcl added the needs-triage Needs looking at to decide what to do label Oct 13, 2022
@Steve-Mcl Steve-Mcl mentioned this issue Oct 13, 2022
Merged
@Steve-Mcl Steve-Mcl added this to the 1.0 milestone Oct 13, 2022
@joepavitt joepavitt added bug Something isn't working good first issue Good for newcomers area:frontend For any issues that require work in the frontend/UI size:S - 2 Sizing estimation point and removed needs-triage Needs looking at to decide what to do labels Oct 14, 2022
@Pezmc Pezmc mentioned this issue Oct 19, 2022
Merged
@Pezmc
Copy link
Contributor

Pezmc commented Oct 27, 2022

Verified on staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pezmc Pezmc

@joepavitt joepavitt

Labels
area:frontend For any issues that require work in the frontend/UI bug Something isn't working good first issue Good for newcomers size:S - 2 Sizing estimation point
Projects
🛠 Development
Archived in project
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Click events in kebab menu's should not bubble FlowFuse/forge-ui-components
3 participants
@Pezmc @Steve-Mcl @joepavitt