Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Impossible to define full msg from `ui-template #427

Closed
joepavitt opened this issue Dec 10, 2023 · 3 comments · Fixed by #510
Closed

Bug: Impossible to define full msg from `ui-template #427

joepavitt opened this issue Dec 10, 2023 · 3 comments · Fixed by #510
Assignees
Labels
bug Something isn't working Dashboard 1.0 This is a feature of Dashboard 1.0 that has not yet been migrated to Dashboard 2.0 size:M - 3 Sizing estimation point

Comments

@joepavitt
Copy link
Collaborator

Description

Due to the underlying handlers for the this.send() function, it is expected that this will just send a value, and not a full msg object. We had a handler in place to prevent duplicate payload nesting, but this just surfaces that one value. Instead, we should treat anything sent via on-action or on-change as the full msg object.

This will require updating of pretty much every component, but will at least then enable the sending of a full msg object from `ui-template.

Epic/Story

No response

Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate

@joepavitt joepavitt added task A piece of work that isn't necessarily tied to a specific Epic or Story. size:M - 3 Sizing estimation point bug Something isn't working Dashboard 1.0 This is a feature of Dashboard 1.0 that has not yet been migrated to Dashboard 2.0 and removed task A piece of work that isn't necessarily tied to a specific Epic or Story. labels Dec 10, 2023
@gemini86
Copy link

Okay I'm finally finding this issue after trying to set the topic on an outgoing message with no success. Could we at least in the meantime add this note to the docs?

@joepavitt
Copy link
Collaborator Author

Could we at least in the meantime add this note to the docs?

I will make it so

@joepavitt
Copy link
Collaborator Author

from https://discourse.nodered.org/t/dashboard-2-beta-development/83550/54?u=joepavitt

One other point, if false or 0 are sent they are ignored so somewhere something is ignoring anything that does not compute as truthy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Dashboard 1.0 This is a feature of Dashboard 1.0 that has not yet been migrated to Dashboard 2.0 size:M - 3 Sizing estimation point
Projects
Status: Under Review
2 participants