Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghost ui-text in group after node deletion #612

Closed
Soiski71 opened this issue Feb 25, 2024 · 3 comments · Fixed by #745
Closed

ghost ui-text in group after node deletion #612

Soiski71 opened this issue Feb 25, 2024 · 3 comments · Fixed by #745
Assignees
Labels
bug Something isn't working size:S - 2 Sizing estimation point

Comments

@Soiski71
Copy link

I'm seeing this in couple cases when using ui-text (to play around and learning) that even after the deletion of the ui-text node the text is rendered in the group. I have restarted node-red and refreshed and deleted the browser cache of the pages, but it does not help?

Node Red version 3.1.5 and @FlowFuse dashboard2 ver.1.2.0

Sample screen (ghosts in the red arrows)
image

View page source shows them here.

image

@joepavitt joepavitt added bug Something isn't working size:S - 2 Sizing estimation point labels Feb 25, 2024
@tmichaeltx
Copy link

tmichaeltx commented Mar 3, 2024

While I can't provide the same details as I deleted the page and then rebuilt without it, I will note that I had the same experience with the table component (plus the text label component that initiated the bug).

As a result, I think it may be something common to how dashboard 2 handles deleted nodes in general and not the text label node alone.

@joepavitt joepavitt self-assigned this Apr 4, 2024
@joepavitt
Copy link
Collaborator

Just tried:

  1. Add ui-text
  2. Full Deploy
  3. View Dashboard - widget is present
  4. Delete ui-text
  5. Full Deploy
  6. View Dashboard - widget is not present

Which is the behaviour I would expect. Going to try a partial deploy next.

@joepavitt
Copy link
Collaborator

joepavitt commented Apr 4, 2024

Yep, partial deploy causes the problem - suspecting we're caching something in ui-base, and so the widget is not cleared from the list. Will dive in further and get it fixed.

Steps to reproduce:

  1. Add ui-text
  2. Full Deploy
  3. View Dashboard - widget is present
  4. Delete ui-text
  5. Partial Deploy
  6. View Dashboard - widget is present

Performing a "Full Deploy" again after this, does resolve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:S - 2 Sizing estimation point
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants