Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding font-awesome-iron-iconset makes the UploadHandler component from Viritin disappear from my page. #108

Closed
jorgheymans opened this issue May 3, 2024 · 7 comments

Comments

@jorgheymans
Copy link

Could it be that these 2 add-ons are conflicting somehow? Initially logged here viritin/flow-viritin#60

@paodb paodb added this to Inbox (needs triage) in Flowing Code Addons (legacy) via automation May 3, 2024
@jorgheymans
Copy link
Author

jorgheymans commented May 4, 2024

To reproduce:

  • clone https://github.com/vaadin/skeleton-starter-flow-spring
  • Add these dependencies in pom.xml
     <dependency>
       <groupId>in.virit</groupId>
       <artifactId>viritin</artifactId>
       <version>2.8.15</version>
     </dependency>
     <dependency>
       <groupId>com.flowingcode.addons</groupId>
       <artifactId>font-awesome-iron-iconset</artifactId>
       <version>5.2.2</version>
     </dependency>
  • Change MainView.java to be just this:
@Route
public class MainView extends VerticalLayout {
    public MainView(@Autowired GreetService service) {

        add(new UploadFileHandler((content, fileName, mimeType) -> {
        }));
    }
}
  • mvn clean spring-boot:run, you will notice the widget being shown in the view.
  • mvn com.vaadin:vaadin-maven-plugin:clean-frontend
  • mvn clean spring-boot:run -Pproduction and the widget disappears from the view.
  • Remove the font-awesome-iron-iconset dependency
  • mvn com.vaadin:vaadin-maven-plugin:clean-frontend
  • mvn clean spring-boot:run -Pproduction, the upload widget appears again.

@javier-godoy
Copy link
Member

Hello. Which exact version of Vaadin are you using? Is there any error message in the browser console?

@jorgheymans
Copy link
Author

jorgheymans commented May 5, 2024

24.3.10, there are no errors reported in the browser console.

@jorgheymans
Copy link
Author

I have tried older versions (up to 2.8.5) of the viritin add-on, but the problem persists. It always works in development mode, but never in production mode. It seems that these 2 add-ons are stepping on each other toes somehow. If there is anything i can do to debug this, happy to help.

@javier-godoy javier-godoy moved this from Inbox (needs triage) to To Do in Flowing Code Addons (legacy) May 6, 2024
@jorgheymans
Copy link
Author

I just figured out that setting <optimizeBundle>false</optimizeBundle> on the vaadin-maven-plugin fixes things. So this is likely a bug in Vaadin and not this plugin.

@jorgheymans
Copy link
Author

This was fixed in Viritin, so i think the issue can be closed here.

@javier-godoy
Copy link
Member

Thanks for confirming that this issue has been fixed in Viritin. If you encounter any further issues or have additional questions, please feel free to open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants