Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addValueChangeListener always return fromClient = true #106

Closed
jcgueriaud1 opened this issue Aug 17, 2022 · 1 comment · Fixed by #107
Closed

addValueChangeListener always return fromClient = true #106

jcgueriaud1 opened this issue Aug 17, 2022 · 1 comment · Fixed by #107
Labels
bug
Projects
Flowing Code Addons (legacy)

Comments

@jcgueriaud1
Copy link
Contributor

In the code the addValueChangeListener always return isFromClient = true even if the event is coming from the server.

https://github.com/FlowingCode/TwinColGridAddon/blob/master/src/main/java/com/flowingcode/vaadin/addons/twincolgrid/TwinColGrid.java#L765

Maybe one solution is to change the signature of the updateSelection with a new parameter isFromClient
@jcgueriaud1 jcgueriaud1 mentioned this issue Aug 17, 2022
Merged
@javier-godoy javier-godoy added this to Inbox (needs triage) in Flowing Code Addons (legacy) via automation Aug 17, 2022
Flowing Code Addons (legacy) automation moved this from Inbox (needs triage) to Done Aug 17, 2022
@javier-godoy
Copy link
Member

Thanks for the PR! The fix has been released in version 2.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
Flowing Code Addons
Status: Done
Flowing Code Addons (legacy)
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/106 is from client jcgueriaud1/TwinColGridAddon
2 participants
@javier-godoy @jcgueriaud1