Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have generate-jwt accept named arguments instead of positional ones #735

Closed
maxalbert opened this issue May 9, 2019 · 0 comments · Fixed by #864
Closed

Have generate-jwt accept named arguments instead of positional ones #735

maxalbert opened this issue May 9, 2019 · 0 comments · Fixed by #864
Labels
enhancement New feature or request

Comments

@maxalbert
Copy link
Contributor

Spinning out of a comment on PR #733:

Currently the generate-jwt CLI utility accepts positional arguments:

generate-jwt TEST_USER SECRET 1 TEST_SERVER --all-access http://localhost:9090

For readability (and to avoid accidentally mixing up the order), it would be nice to have these as named arguments instead:

generate-jwt --all-access \
    --username TEST_USER \
    --secret-key SECRET \
    --lifetime 1 \
    --flowapi-server-name TEST_SERVER \
    http://localhost:9090
@maxalbert maxalbert added the enhancement New feature or request label May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant